Re: [PATCH v4] drm/i915/hwmon: expose fan speed

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Aug 13, 2024 at 03:53:25PM +0300, Raag Jadav wrote:
> On Tue, Aug 13, 2024 at 02:47:27PM +0300, Andy Shevchenko wrote:
> > On Tue, Aug 13, 2024 at 02:23:13PM +0300, Raag Jadav wrote:
> > > On Fri, Aug 09, 2024 at 02:48:08PM +0300, Andy Shevchenko wrote:
> > > > On Fri, Aug 09, 2024 at 11:45:25AM +0530, Raag Jadav wrote:

...

> > > > > +	/*
> > > > > +	 * HW register value is accumulated count of pulses from
> > > > > +	 * PWM fan with the scale of 2 pulses per rotation.
> > > > > +	 */
> > > > > +	rotations = pulses >> 1;
> > > > 
> > > > In accordance with the comment the
> > > > 
> > > > 	rotations = pulses / 2;
> > > > 
> > > > looks better.
> > > 
> > > This change seems to cause a build error in v5.
> > > Something to do with __udivdi3 on i386.
> > 
> > No, it's not this change.
> > Please, read report carefully.
> 
> CI seems to point to DIV_ROUND_UP(), but it's been there since v1.
> So not sure if I entirely understand.

Yes, that's the issue. You always can reproduce on your side. LKP sent you
comprehensive information about their setup.

-- 
With Best Regards,
Andy Shevchenko





[Index of Archives]     [AMD Graphics]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux