On Mon, Aug 05, 2024 at 05:46:06PM +0200, Krzysztof Niemiec wrote: > On 2024-08-01 at 17:40:48 GMT, Krzysztof Niemiec wrote: > > While the sysfs entries for engines are added in intel_engines_init() > > during driver load, the corresponding function intel_engines_release() > > does not correctly get rid of them. This can lead to a UAF if, after > > failed initialization (for example when gt is set wedged on init), we > > try to access the engines. > > > > Empty the engines llist in intel_engines_release(). > > > > Suggested-by: Chris Wilson <chris.p.wilson@xxxxxxxxxxxxxxx> > > Signed-off-by: Krzysztof Niemiec <krzysztof.niemiec@xxxxxxxxx> ... > drm/i915/gt: Empty uabi engines list during intel_engines_release() > > While the uabi_engines_llist is populated in intel_engines_init() during > driver load, the corresponding function intel_engines_release() does not > correctly get rid of it. This can lead to a UAF if, after failed > initialization (for example when gt is set wedged on init), we try to > access the engines. Pushed to drm-intel-gt-next with the updated commit. Thanks, Andi
