On Thu, Jul 25, 2024 at 10:58:08AM -0500, Dan Carpenter wrote: > On Thu, Jul 25, 2024 at 08:48:35AM +0100, Tvrtko Ursulin wrote: > > > > Hi, > > > > On 12/07/2024 22:41, Jonathan Cavitt wrote: > > > Prevent a NULL pointer access in intel_memory_regions_hw_probe. > > > > For future reference please include some impact assessment in patches tagged > > as fixes. Makes maintainers job, and even anyone's who tries to backport > > stuff to stable at some future date, much easier if it is known how > > important is the fix and in what circumstances can the problem it is fixing > > trigger. > > > > As someone doing backport work, I think this patch is fine. Everyone > knows the impact of a NULL dereference in probe(). > > I guess with patches that add NULL dereferences, the trick is s/dereferences/checks/ > understanding when people are adding NULL checks to make a static > checker happy or when it's a real bug. regards, dan carpenter
