> -----Original Message----- > From: Intel-xe <intel-xe-bounces@xxxxxxxxxxxxxxxxxxxxx> On Behalf Of Ville Syrjala > Sent: Friday, July 5, 2024 8:23 PM > To: intel-gfx@xxxxxxxxxxxxxxxxxxxxx > Cc: intel-xe@xxxxxxxxxxxxxxxxxxxxx > Subject: [PATCH 15/20] drm/xe/fbdev: Fix BIOS FB vs.s stolen size checke Nit: Typo in vs and check > From: Ville Syrjälä <ville.syrjala@xxxxxxxxxxxxxxx> > > Looks like stolen->size is in bytes, not pages. Remove the bogus PAGE_SHIFT stuff. > > Also for some rnadom reason xe rejects the FB if it takes up exactly half of stolen, Typo in random. > whereas i915 allows it to be used in that case. Adjust xe to follow the i915 rule for > consistency. With the typos fixed, Looks Good to me. Reviewed-by: Uma Shankar <uma.shankar@xxxxxxxxx> > Signed-off-by: Ville Syrjälä <ville.syrjala@xxxxxxxxxxxxxxx> > --- > drivers/gpu/drm/xe/display/xe_plane_initial.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/xe/display/xe_plane_initial.c > b/drivers/gpu/drm/xe/display/xe_plane_initial.c > index 5eccd6abb3ef..21965cc8a9ca 100644 > --- a/drivers/gpu/drm/xe/display/xe_plane_initial.c > +++ b/drivers/gpu/drm/xe/display/xe_plane_initial.c > @@ -110,7 +110,7 @@ initial_plane_bo(struct xe_device *xe, > * features. > */ > if (IS_ENABLED(CONFIG_FRAMEBUFFER_CONSOLE) && > - plane_config->size * 2 >> PAGE_SHIFT >= stolen->size) > + plane_config->size * 2 > stolen->size) > return NULL; > } > > -- > 2.44.2
