On Fri, 28 Jun 2024, Lucas De Marchi <lucas.demarchi@xxxxxxxxx> wrote: > On Fri, Jun 28, 2024 at 02:36:16PM GMT, Rodrigo Vivi wrote: >>Fair enough. Perhaps we could at least define this in i915_drv.h so we implement >>in the compat headers and avoid the ifdef I915? > > yeah, I'm fine with that approach. Based on Lucas' feedback [1] on v2, looks like we'll need the .c file anyway. Whether that's then wrapped in intel_display_wa.h with #ifdef I915, or i915_drv.h, up to you. Also, for the record, Acked-by: Jani Nikula <jani.nikula@xxxxxxxxx> on merging this via drm-xe-next. BR, Jani. [1] https://lore.kernel.org/r/6hq2htqmbjjhrdad3jbgsesvteqe3g65hpznzsyk6bxj42iowq@my4rit2pa4sm -- Jani Nikula, Intel
