> -----Original Message----- > From: Nikula, Jani <jani.nikula@xxxxxxxxx> > Sent: Tuesday, July 2, 2024 1:39 PM > To: Manna, Animesh <animesh.manna@xxxxxxxxx>; intel- > gfx@xxxxxxxxxxxxxxxxxxxxx > Cc: ville.syrjala@xxxxxxxxxxxxxxx; Hogander, Jouni > <jouni.hogander@xxxxxxxxx>; Murthy, Arun R <arun.r.murthy@xxxxxxxxx>; > Nautiyal, Ankit K <ankit.k.nautiyal@xxxxxxxxx>; Golani, Mitulkumar Ajitkumar > <mitulkumar.ajitkumar.golani@xxxxxxxxx>; Manna, Animesh > <animesh.manna@xxxxxxxxx> > Subject: Re: [PATCH v8 1/2] drm/i915/panelreplay: Panel replay workaround > with VRR > > On Tue, 02 Jul 2024, Animesh Manna <animesh.manna@xxxxxxxxx> wrote: > > Panel Replay VSC SDP not getting sent when VRR is enabled and W1 and > > W2 are 0. So Program Set Context Latency in > TRANS_SET_CONTEXT_LATENCY > > register to at least a value of 1. > > The patch does a whole lot more than what's explained in the commit > message. Feels like the patch should maybe do less. > > > > > HSD: 14015406119 > > > > v1: Initial version. > > v2: Update timings stored in adjusted_mode struct. [Ville] > > v3: Add WA in compute_config(). [Ville] > > v4: > > - Add DISPLAY_VER() check and improve code comment. [Rodrigo] > > - Introduce centralized intel_crtc_vblank_delay(). [Ville] > > v5: Move to crtc_compute_config(). [Ville] > > v6: Restrict DISPLAY_VER till 14. [Mitul] > > v7: > > - Corrected code-comment. [Mitul] > > - dev_priv local variable removed. [Jani] > > v8: Introduce late_compute_config() which will take care late > > vblank-delay adjustment. [Ville] > > I presume this change is based on [1], but I have a hard time mentally > mapping what's going on in the patch to what Ville asks there. > > [1] https://lore.kernel.org/r/ZnlvWk-sOzDfMa0E@xxxxxxxxx
