Quoting Matt Roper (2024-06-26 14:57:58-03:00) >On Tue, Jun 25, 2024 at 05:26:52PM -0300, Gustavo Sousa wrote: >> Starting with Xe_LPDP, support for Type-C connections is provided by > >Drive-by nitpick: In human-readable text like comments and commit >messages, the official name of the IP is "Xe_LPD+." We only need to >replace the "+" with a "P" in code identifiers where a symbol wouldn't >be legal. Yeah... I was unsure between the two forms and was afraid that the "+" in "Xe_LPD+" could somehow be misinterpreted as "and higher", so I ended up going with the other one. I'll update to use the official name while applying. Thanks! -- Gustavo Sousa > > >Matt > >> PICA and programming PORT_TX_DFLEXDPMLE1(*) registers is not applicable >> anymore. Those registers don't even exist in recent display IPs. As >> such, skip programming them. >> >> Bspec: 65750, 65448 >> Signed-off-by: Gustavo Sousa <gustavo.sousa@xxxxxxxxx> >> --- >> drivers/gpu/drm/i915/display/intel_tc.c | 3 +++ >> 1 file changed, 3 insertions(+) >> >> diff --git a/drivers/gpu/drm/i915/display/intel_tc.c b/drivers/gpu/drm/i915/display/intel_tc.c >> index 9887967b2ca5..6f2ee7dbc43b 100644 >> --- a/drivers/gpu/drm/i915/display/intel_tc.c >> +++ b/drivers/gpu/drm/i915/display/intel_tc.c >> @@ -393,6 +393,9 @@ void intel_tc_port_set_fia_lane_count(struct intel_digital_port *dig_port, >> bool lane_reversal = dig_port->saved_port_bits & DDI_BUF_PORT_REVERSAL; >> u32 val; >> >> + if (DISPLAY_VER(i915) >= 14) >> + return; >> + >> drm_WARN_ON(&i915->drm, >> lane_reversal && tc->mode != TC_PORT_LEGACY); >> >> -- >> 2.45.2 >> > >-- >Matt Roper >Graphics Software Engineer >Linux GPU Platform Enablement >Intel Corporation
