== Series Details == Series: Ultrajoiner basic functionality series (rev4) URL : https://patchwork.freedesktop.org/series/133800/ State : warning == Summary == Error: dim checkpatch failed 89c7a081cd07 drm/i915: Add some essential functionality for joiners -:61: ERROR:OPEN_BRACE: that open brace { should be on the previous line #61: FILE: drivers/gpu/drm/i915/display/intel_display.c:277: + for (i = lsb; i < msb; i += 4) + { total: 1 errors, 0 warnings, 0 checks, 160 lines checked 13a76717f0ea drm/i915: Implement hw state readout for ultrajoiner -:15: WARNING:BAD_SIGN_OFF: 'Signed-off-by:' is the preferred signature form #15: SIgned-off-by: Stanislav Lisovskiy <stanislav.lisovskiy@xxxxxxxxx> -:95: CHECK:SPACING: No space is necessary after a cast #95: FILE: drivers/gpu/drm/i915/display/intel_display.c:3666: + power_domain = intel_dsc_power_domain(crtc, (enum transcoder) pipe); -:152: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis #152: FILE: drivers/gpu/drm/i915/display/intel_display.c:3717: + drm_WARN(&dev_priv->drm, + (ultrajoiner_pipes & bigjoiner_pipes) == ultrajoiner_pipes, -:181: WARNING:UNNECESSARY_ELSE: else is not generally useful after a break or return #181: FILE: drivers/gpu/drm/i915/display/intel_display.c:3743: + return fls(primary_pipes) - 1; + } else { -:231: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis #231: FILE: drivers/gpu/drm/i915/display/intel_display.c:3847: + get_joiner_primary_pipe(crtc->pipe, primary_pipes, + secondary_pipes, ultrajoiner_used); total: 0 errors, 2 warnings, 3 checks, 238 lines checked 70a12a4c8a8f drm/i915: Compute config and mode valid changes for ultrajoiner -:66: CHECK:MULTIPLE_ASSIGNMENTS: multiple assignments should be avoided #66: FILE: drivers/gpu/drm/i915/display/intel_dp.c:769: + max_bpp_joiner = max_bpp_small_joiner_ram = -:213: ERROR:ELSE_AFTER_BRACE: else should follow close brace '}' #213: FILE: drivers/gpu/drm/i915/display/intel_dp.c:1279: + } + else if (intel_dp_need_bigjoiner(intel_dp, connector, -:214: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis #214: FILE: drivers/gpu/drm/i915/display/intel_dp.c:1280: + else if (intel_dp_need_bigjoiner(intel_dp, connector, + mode->hdisplay, target_clock)) { -:330: WARNING:LONG_LINE: line length of 104 exceeds 100 columns #330: FILE: drivers/gpu/drm/i915/display/intel_dp.h:125: +bool intel_dp_joiner_needs_dsc(struct drm_i915_private *i915, bool use_bigjoiner, bool use_ultrajoiner); -:388: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis #388: FILE: drivers/gpu/drm/i915/display/intel_dp_mst.c:583: + else if (intel_dp_need_bigjoiner(intel_dp, connector, + adjusted_mode->crtc_hdisplay, -:503: CHECK:LINE_SPACING: Please don't use multiple blank lines #503: FILE: drivers/gpu/drm/i915/display/intel_hdmi.c:2355: + + -:559: WARNING:ONE_SEMICOLON: Statements terminations use 1 semicolon #559: FILE: drivers/gpu/drm/i915/display/intel_vdsc.c:812: + dss_ctl1_val |= PRIMARY_ULTRA_JOINER_ENABLE;; total: 1 errors, 2 warnings, 4 checks, 487 lines checked 808815fb696e drm/i915: Add new abstraction layer to handle pipe order for different joiners -:7: WARNING:COMMIT_LOG_LONG_LINE: Prefer a maximum 75 chars per line (possible unwrapped commit description?) #7: Ultrajoiner case requires special treatment where both reverse and staight order -:77: CHECK:LINE_SPACING: Please don't use multiple blank lines #77: FILE: drivers/gpu/drm/i915/display/intel_display.c:1724: + -:82: ERROR:OPEN_BRACE: that open brace { should be on the previous line #82: FILE: drivers/gpu/drm/i915/display/intel_display.c:1729: + static const enum pipe ultrajoiner_pipe_order_enable[I915_MAX_PIPES] = + { PIPE_B, PIPE_D, PIPE_C, PIPE_A }; -:84: ERROR:OPEN_BRACE: that open brace { should be on the previous line #84: FILE: drivers/gpu/drm/i915/display/intel_display.c:1731: + static const enum pipe bigjoiner_pipe_order_enable[I915_MAX_PIPES] = + { PIPE_B, PIPE_A, PIPE_D, PIPE_C }; -:86: ERROR:OPEN_BRACE: that open brace { should be on the previous line #86: FILE: drivers/gpu/drm/i915/display/intel_display.c:1733: + static const enum pipe nojoiner_pipe_order_enable[I915_MAX_PIPES] = + { PIPE_A, PIPE_B, PIPE_C, PIPE_D }; -:98: ERROR:OPEN_BRACE: that open brace { should be on the previous line #98: FILE: drivers/gpu/drm/i915/display/intel_display.c:1745: + static const enum pipe ultrajoiner_pipe_order_disable[I915_MAX_PIPES] = + { PIPE_A, PIPE_B, PIPE_D, PIPE_C }; -:100: ERROR:OPEN_BRACE: that open brace { should be on the previous line #100: FILE: drivers/gpu/drm/i915/display/intel_display.c:1747: + static const enum pipe bigjoiner_pipe_order_disable[I915_MAX_PIPES] = + { PIPE_A, PIPE_B, PIPE_C, PIPE_D }; -:102: ERROR:OPEN_BRACE: that open brace { should be on the previous line #102: FILE: drivers/gpu/drm/i915/display/intel_display.c:1749: + static const enum pipe nojoiner_pipe_order_disable[I915_MAX_PIPES] = + { PIPE_A, PIPE_B, PIPE_C, PIPE_D }; -:218: ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses #218: FILE: drivers/gpu/drm/i915/display/intel_display.h:277: +#define for_each_intel_crtc_in_mask_priority(__dev_priv, intel_crtc, __p, __mask, __priolist) \ + for_each_pipe(__dev_priv, __p) \ + for_each_if((__mask) & BIT(__priolist[__p])) \ + for_each_if(intel_crtc = intel_crtc_for_pipe(__dev_priv, __priolist[__p])) -:218: CHECK:MACRO_ARG_REUSE: Macro argument reuse '__dev_priv' - possible side-effects? #218: FILE: drivers/gpu/drm/i915/display/intel_display.h:277: +#define for_each_intel_crtc_in_mask_priority(__dev_priv, intel_crtc, __p, __mask, __priolist) \ + for_each_pipe(__dev_priv, __p) \ + for_each_if((__mask) & BIT(__priolist[__p])) \ + for_each_if(intel_crtc = intel_crtc_for_pipe(__dev_priv, __priolist[__p])) -:218: CHECK:MACRO_ARG_REUSE: Macro argument reuse '__p' - possible side-effects? #218: FILE: drivers/gpu/drm/i915/display/intel_display.h:277: +#define for_each_intel_crtc_in_mask_priority(__dev_priv, intel_crtc, __p, __mask, __priolist) \ + for_each_pipe(__dev_priv, __p) \ + for_each_if((__mask) & BIT(__priolist[__p])) \ + for_each_if(intel_crtc = intel_crtc_for_pipe(__dev_priv, __priolist[__p])) -:218: CHECK:MACRO_ARG_REUSE: Macro argument reuse '__priolist' - possible side-effects? #218: FILE: drivers/gpu/drm/i915/display/intel_display.h:277: +#define for_each_intel_crtc_in_mask_priority(__dev_priv, intel_crtc, __p, __mask, __priolist) \ + for_each_pipe(__dev_priv, __p) \ + for_each_if((__mask) & BIT(__priolist[__p])) \ + for_each_if(intel_crtc = intel_crtc_for_pipe(__dev_priv, __priolist[__p])) total: 7 errors, 1 warnings, 4 checks, 241 lines checked
