> -----Original Message----- > From: Hogander, Jouni <jouni.hogander@xxxxxxxxx> > Sent: Wednesday, June 19, 2024 11:51 AM > To: intel-gfx@xxxxxxxxxxxxxxxxxxxxx > Cc: Manna, Animesh <animesh.manna@xxxxxxxxx>; Kahola, Mika > <mika.kahola@xxxxxxxxx>; Hogander, Jouni <jouni.hogander@xxxxxxxxx> > Subject: [PATCH v9 00/11] Panel Replay eDP support > > This patch set is implementing eDP1.5 Panel Replay for Intel hw and enabling > it on LunarLake HW when eDP1.5 panel is available. Patches are tested using > two differenet eDP1.5 panel models. IGT modifications for testing are under > review and available here: > > https://patchwork.freedesktop.org/series/133866/ > > v9: > - rebase (part of v8 set is merged) > v8: > - series reordered to ease merging subset > - wa 16021440873 modified > - Fix port clock usage in AUX Less wake time calculation > - Disable PSR/Panel Replay on sink side for PSR only > v7: > - fix improper SU area width > - writing wrong register in Wa 16021440873 > - disable Panel Replay if psr_enable is set != -1 > - perfrom ALPM check for Panel Replay Full Frame update > - printout why Panel Replay is disabled > v6: > - fix and rework sink enable > - rework checking vblank length for LunarLake and Panel Replay > - reorder patches > v5: > - use psr->su_region_et_enabled instead of psr2_su_region_et_valid > - do not check Vblank >= PSR2_CTL Block Count Number for Panel Replay > v4: > - add some patch from "Panel Replay fixes" set here > - check 128b/132b encoding and HDCP enable > - use intel_alpm_aux_wake_supported instead of local variable > - printout debug info in case Panel Replay is prevented > v3: > - commit message modifications > - s/intel_psr_psr_mode/intel_psr_print_mode/ > - remove extra space from "PSR mode: disabled" > - do not allow eDP Panel Replay when using 128b/132b encoding > - do not allow eDP Panel Replay when HDCP is enabled > v2: > - printout "Selective Update enabled (Early Transport)" instead of > "Selective Update Early Transport enabled" > - ensure that fastset is performed when the disable bit changes > > Jouni Högander (11): > drm/i915/psr: Check panel ALPM capability for eDP Panel Replay > drm/i915/psr: Inform Panel Replay source support on eDP as well > drm/i915/psr: enable sink for eDP1.5 Panel Replay > drm/i915/psr: Check panel Early Transport capability for eDP PR > drm/i915/psr: 128b/132b Panel Replay is not supported on eDP > drm/i915/psr: HW will not allow PR on eDP when HDCP enabled > drm/i915/alpm: Make crtc_state as const in intel_alpm_compute_params > drm/i915/psr: Perform psr2 checks related to ALPM for Panel Replay > drm/i915/psr: Perform scanline indication check for Panel Replay as > well > drm/i915/psr: Check Early Transport for Panel Replay as well > drm/i915/psr: Modify dg2_activate_panel_replay to support eDP The changes look good to me for overall patch set, with fix of Jani's comment on patch1 Reviewed-by: Animesh Manna <animesh.manna@xxxxxxxxx> > > drivers/gpu/drm/i915/display/intel_alpm.c | 9 +- > drivers/gpu/drm/i915/display/intel_alpm.h | 2 +- > drivers/gpu/drm/i915/display/intel_psr.c | 163 +++++++++++++++++----- > 3 files changed, 137 insertions(+), 37 deletions(-) > > -- > 2.34.1
