On Thu, 2024-06-20 at 15:06 +0000, Manna, Animesh wrote:
>
>
> > -----Original Message-----
> > From: Hogander, Jouni <jouni.hogander@xxxxxxxxx>
> > Sent: Thursday, June 20, 2024 4:03 PM
> > To: intel-gfx@xxxxxxxxxxxxxxxxxxxxx
> > Cc: Manna, Animesh <animesh.manna@xxxxxxxxx>; Hogander, Jouni
> > <jouni.hogander@xxxxxxxxx>
> > Subject: [PATCH] drm/i915/psr: Set
> > DP_PSR_SU_REGION_SCANLINE_CAPTURE bit when needed
> >
> > Setting DP_PSR_SU_REGION_SCANLINE_CAPTURE (Selective Update Region
> > Scan Line Capture Indication in spec) bit was dropped when
> > psr_enable_sink
> > was split to _psr_enable_sink and _panel_replay_enable_sink. Add
> > setting it
> > back.
> >
> > Fixes: 32f0045f905c ("drm/i915/psr: Split enabling sink for PSR and
> > Panel
> > Replay")
> > Signed-off-by: Jouni Högander <jouni.hogander@xxxxxxxxx>
>
> Reviewed-by: Animesh Manna <animesh.manna@xxxxxxxxx>
Thank you Animesh for your review. This is now pushed to drm-intel-
next.
BR,
Jouni Högander
>
> > ---
> > drivers/gpu/drm/i915/display/intel_psr.c | 3 +++
> > 1 file changed, 3 insertions(+)
> >
> > diff --git a/drivers/gpu/drm/i915/display/intel_psr.c
> > b/drivers/gpu/drm/i915/display/intel_psr.c
> > index a9d9383e4ee5..0dbcaf644624 100644
> > --- a/drivers/gpu/drm/i915/display/intel_psr.c
> > +++ b/drivers/gpu/drm/i915/display/intel_psr.c
> > @@ -732,6 +732,9 @@ static void _psr_enable_sink(struct intel_dp
> > *intel_dp,
> > val |= DP_PSR_CRC_VERIFICATION;
> > }
> >
> > + if (crtc_state->req_psr2_sdp_prior_scanline)
> > + val |= DP_PSR_SU_REGION_SCANLINE_CAPTURE;
> > +
> > if (crtc_state->enable_psr2_su_region_et)
> > val |= DP_PANEL_REPLAY_ENABLE_SU_REGION_ET;
> >
> > --
> > 2.34.1
>
