RE: [PATCH v8 03/20] drm/i915/alpm: Fix port clock usage in AUX Less wake time calculation

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




> -----Original Message-----
> From: Hogander, Jouni <jouni.hogander@xxxxxxxxx>
> Sent: Thursday, June 13, 2024 3:02 PM
> To: intel-gfx@xxxxxxxxxxxxxxxxxxxxx
> Cc: Manna, Animesh <animesh.manna@xxxxxxxxx>; Kahola, Mika
> <mika.kahola@xxxxxxxxx>; Hogander, Jouni <jouni.hogander@xxxxxxxxx>
> Subject: [PATCH v8 03/20] drm/i915/alpm: Fix port clock usage in AUX Less
> wake time calculation
> 
> Port clock is link rate in 10 kbit/s units. Take this into account when
> calculating AUX Less wake time.
> 
> Fixes: da6a9836ac09 ("drm/i915/psr: Calculate aux less wake time")
> Signed-off-by: Jouni Högander <jouni.hogander@xxxxxxxxx>

Reviewed-by: Animesh Manna <animesh.manna@xxxxxxxxx>

> ---
>  drivers/gpu/drm/i915/display/intel_alpm.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/i915/display/intel_alpm.c
> b/drivers/gpu/drm/i915/display/intel_alpm.c
> index 90072f6e3a33..67848fc1e24d 100644
> --- a/drivers/gpu/drm/i915/display/intel_alpm.c
> +++ b/drivers/gpu/drm/i915/display/intel_alpm.c
> @@ -125,7 +125,8 @@ static int _lnl_compute_aux_less_wake_time(int
> port_clock)
>  	int tsilence_max = 180;
>  	int t1 = 50 * 1000;
>  	int tps4 = 252;
> -	int tml_phy_lock = 1000 * 1000 * tps4 * 10 / port_clock;
> +	/* port_clock is link rate in 10kbit/s units */
> +	int tml_phy_lock = 1000 * 1000 * tps4 / port_clock;
>  	int num_ml_phy_lock = 7 + DIV_ROUND_UP(6500, tml_phy_lock) + 1;
>  	int t2 = num_ml_phy_lock * tml_phy_lock;
>  	int tcds = 1 * t2;
> --
> 2.34.1





[Index of Archives]     [AMD Graphics]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux