Re: [PATCH] drm/i915/gt: Delete the live_hearbeat_fast selftest

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Tvrtko,

On Mon, Jun 10, 2024 at 12:42:31PM +0100, Tvrtko Ursulin wrote:
> On 03/06/2024 17:20, Niemiec, Krzysztof wrote:
> > The test is trying to push the heartbeat frequency to the limit, which
> > might sometimes fail. Such a failure does not provide valuable
> > information, because it does not indicate that there is something
> > necessarily wrong with either the driver or the hardware.
> > 
> > Remove the test to prevent random, unnecessary failures from appearing
> > in CI.
> > 
> > Suggested-by: Chris Wilson <chris.p.wilson@xxxxxxxxx>
> > Signed-off-by: Niemiec, Krzysztof <krzysztof.niemiec@xxxxxxxxx>
> 
> Just a note in passing that comma in the email display name is I believe not
> RFC 5322 compliant and there might be tools which barf on it(*). If you can
> put it in double quotes, it would be advisable.

yes, we discussed it with Krzysztof, I noticed it right after I
submitted the code.

> Regards,
> 
> Tvrtko
> 
> *) Such as my internal pull request generator which uses CPAN's
> Email::Address::XS. :)

If we are in time, we can fix it as Krzysztof Niemiec <krzysztof.niemiec@xxxxxxxxx>

Sorry about this oversight,
Andi



[Index of Archives]     [AMD Graphics]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux