Hi Jani, > -----Original Message----- > From: Nikula, Jani <jani.nikula@xxxxxxxxx> > Sent: Friday, May 31, 2024 5:32 PM > To: Golani, Mitulkumar Ajitkumar <mitulkumar.ajitkumar.golani@xxxxxxxxx>; > intel-gfx@xxxxxxxxxxxxxxxxxxxxx > Cc: Nautiyal, Ankit K <ankit.k.nautiyal@xxxxxxxxx> > Subject: RE: [PATCH v10 1/8] drm/i915: Separate VRR related register > definitions > > On Fri, 31 May 2024, "Golani, Mitulkumar Ajitkumar" > <mitulkumar.ajitkumar.golani@xxxxxxxxx> wrote: > > Hi Jani, > > > >> -----Original Message----- > >> From: Nikula, Jani <jani.nikula@xxxxxxxxx> > >> Sent: Thursday, May 30, 2024 7:19 PM > >> To: Golani, Mitulkumar Ajitkumar > >> <mitulkumar.ajitkumar.golani@xxxxxxxxx>; > >> intel-gfx@xxxxxxxxxxxxxxxxxxxxx > >> Cc: dri-devel@xxxxxxxxxxxxxxxxxxxxx; Nautiyal, Ankit K > >> <ankit.k.nautiyal@xxxxxxxxx> > >> Subject: Re: [PATCH v10 1/8] drm/i915: Separate VRR related register > >> definitions > >> > >> On Thu, 30 May 2024, Mitul Golani > >> <mitulkumar.ajitkumar.golani@xxxxxxxxx> > >> wrote: > >> > Move VRR related register definitions to a separate file called > >> > intel_vrr_regs.h. > >> > >> But this is not just movement... there's a bunch of other (mostly > >> unwanted?) changes there too. > >> > >> 'git show --color-moved' is a powerful tool for reviewing code > >> movement. If it's not just movement, you have to fallback to manual review > of the whole thing. > > > > I have moved the VRR-related registers from i915_reg.h to > > intel_vrr_regs.h and reordered them based on their register offsets. > > However, if preferred, I can move only the VRR-related registers for > > now and handle the reordering in a separate patch series later. Please > > let me know if this approach is acceptable. > > Yes. You can check with 'git show --color-moved'. Also avoid the indentation > changes. > > BR, > Jani. > Sure, I moved the VRR-related registers and fixed some checkpatch issues only with new series. https://patchwork.freedesktop.org/patch/596728/?series=126443&rev=11 Regards, Mitul > > > > > Regards, > > Mitul > >> > >> > Signed-off-by: Mitul Golani <mitulkumar.ajitkumar.golani@xxxxxxxxx> > >> > --- > >> > drivers/gpu/drm/i915/display/intel_vrr.c | 1 + > >> > drivers/gpu/drm/i915/display/intel_vrr_regs.h | 117 > ++++++++++++++++++ > >> > drivers/gpu/drm/i915/i915_reg.h | 100 --------------- > >> > 3 files changed, 118 insertions(+), 100 deletions(-) create mode > >> > 100644 drivers/gpu/drm/i915/display/intel_vrr_regs.h > >> > > > > > -- > Jani Nikula, Intel
