On Fri, 31 May 2024, Ville Syrjälä <ville.syrjala@xxxxxxxxxxxxxxx> wrote: > On Wed, May 29, 2024 at 08:48:07PM +0300, Jani Nikula wrote: >> Include what you use. With this, we can drop the include from xe compat >> i915_drv.h. >> >> Signed-off-by: Jani Nikula <jani.nikula@xxxxxxxxx> >> --- >> drivers/gpu/drm/i915/display/intel_dmc.c | 1 + >> drivers/gpu/drm/xe/compat-i915-headers/i915_drv.h | 1 - >> 2 files changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/drivers/gpu/drm/i915/display/intel_dmc.c b/drivers/gpu/drm/i915/display/intel_dmc.c >> index 63fccdda56c0..b5ebb0f5b269 100644 >> --- a/drivers/gpu/drm/i915/display/intel_dmc.c >> +++ b/drivers/gpu/drm/i915/display/intel_dmc.c >> @@ -26,6 +26,7 @@ >> #include <linux/firmware.h> >> >> #include "i915_drv.h" >> +#include "i915_gpu_error.h" > > Someone should probably convert intel_dmc_print_error_state() > to use the drm_printer interface instead, assuming that is the > only thing that needs this header in intel_dmc.c. I don't disagree, but kind of wanted to keep this series focused on just rearranging the headers. And this serves a purpose: now you can look at the files under display to have a better grasp at what's needed from outside of display. i915_gpu_error.h include flags one case. BR, Jani. -- Jani Nikula, Intel
