On Wed, May 29, 2024 at 08:48:07PM +0300, Jani Nikula wrote: > Include what you use. With this, we can drop the include from xe compat > i915_drv.h. Nice! Reviewed-by: Rodrigo Vivi <rodrigo.vivi@xxxxxxxxx> > > Signed-off-by: Jani Nikula <jani.nikula@xxxxxxxxx> > --- > drivers/gpu/drm/i915/display/intel_dmc.c | 1 + > drivers/gpu/drm/xe/compat-i915-headers/i915_drv.h | 1 - > 2 files changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/i915/display/intel_dmc.c b/drivers/gpu/drm/i915/display/intel_dmc.c > index 63fccdda56c0..b5ebb0f5b269 100644 > --- a/drivers/gpu/drm/i915/display/intel_dmc.c > +++ b/drivers/gpu/drm/i915/display/intel_dmc.c > @@ -26,6 +26,7 @@ > #include <linux/firmware.h> > > #include "i915_drv.h" > +#include "i915_gpu_error.h" > #include "i915_reg.h" > #include "intel_de.h" > #include "intel_dmc.h" > diff --git a/drivers/gpu/drm/xe/compat-i915-headers/i915_drv.h b/drivers/gpu/drm/xe/compat-i915-headers/i915_drv.h > index fb784ab64cd4..9776cc3332fe 100644 > --- a/drivers/gpu/drm/xe/compat-i915-headers/i915_drv.h > +++ b/drivers/gpu/drm/xe/compat-i915-headers/i915_drv.h > @@ -19,7 +19,6 @@ > #include "xe_bo.h" > #include "xe_pm.h" > #include "xe_step.h" > -#include "i915_gpu_error.h" > #include "i915_reg_defs.h" > #include "i915_utils.h" > #include "intel_step.h" > -- > 2.39.2 >
