== Series Details == Series: drm/i915: identify all platforms in display probe (rev2) URL : https://patchwork.freedesktop.org/series/133932/ State : warning == Summary == Error: dim checkpatch failed 4a12935c03fe drm/i915/display: move params copy at probe earlier 9e54c7084bb1 drm/i915/display: change probe for no display case bd215ad1beb8 drm/i915/display: check platforms without display one level higher b3a37780088e drm/i915/display: change GMD ID display ip ver propagation at probe 99943557591a drm/i915/display: add platform descriptors -:52: WARNING:LONG_LINE_COMMENT: line length of 104 exceeds 100 columns #52: FILE: drivers/gpu/drm/i915/display/intel_display_device.c:211: + .__runtime_defaults.port_mask = BIT(PORT_A) | BIT(PORT_B) | BIT(PORT_C), /* DVO A/B/C */ -:239: WARNING:LONG_LINE_COMMENT: line length of 117 exceeds 100 columns #239: FILE: drivers/gpu/drm/i915/display/intel_display_device.c:349: + .__runtime_defaults.port_mask = BIT(PORT_B) | BIT(PORT_C) | BIT(PORT_D), /* SDVO/HDMI/DP B/C, DP D */ -:253: WARNING:LONG_LINE_COMMENT: line length of 117 exceeds 100 columns #253: FILE: drivers/gpu/drm/i915/display/intel_display_device.c:358: + .__runtime_defaults.port_mask = BIT(PORT_B) | BIT(PORT_C) | BIT(PORT_D), /* SDVO/HDMI/DP B/C, DP D */ -:303: WARNING:LONG_LINE: line length of 142 exceeds 100 columns #303: FILE: drivers/gpu/drm/i915/display/intel_display_device.c:400: + .__runtime_defaults.port_mask = BIT(PORT_A) | BIT(PORT_B) | BIT(PORT_C) | BIT(PORT_D), /* DP A, SDVO/HDMI/DP B, HDMI/DP C/D */ -:329: WARNING:LONG_LINE: line length of 142 exceeds 100 columns #329: FILE: drivers/gpu/drm/i915/display/intel_display_device.c:416: + .__runtime_defaults.port_mask = BIT(PORT_A) | BIT(PORT_B) | BIT(PORT_C) | BIT(PORT_D), /* DP A, SDVO/HDMI/DP B, HDMI/DP C/D */ -:396: WARNING:LONG_LINE: line length of 116 exceeds 100 columns #396: FILE: drivers/gpu/drm/i915/display/intel_display_device.c:455: + .__runtime_defaults.port_mask = BIT(PORT_A) | BIT(PORT_B) | BIT(PORT_C) | BIT(PORT_D) | BIT(PORT_E), -:434: WARNING:LONG_LINE: line length of 116 exceeds 100 columns #434: FILE: drivers/gpu/drm/i915/display/intel_display_device.c:477: + .__runtime_defaults.port_mask = BIT(PORT_A) | BIT(PORT_B) | BIT(PORT_C) | BIT(PORT_D) | BIT(PORT_E), -:464: WARNING:LONG_LINE_COMMENT: line length of 108 exceeds 100 columns #464: FILE: drivers/gpu/drm/i915/display/intel_display_device.c:495: + .__runtime_defaults.port_mask = BIT(PORT_B) | BIT(PORT_C) | BIT(PORT_D), /* HDMI/DP B/C/D */ -:546: WARNING:LONG_LINE: line length of 116 exceeds 100 columns #546: FILE: drivers/gpu/drm/i915/display/intel_display_device.c:627: + .__runtime_defaults.port_mask = BIT(PORT_A) | BIT(PORT_B) | BIT(PORT_C) | BIT(PORT_D) | BIT(PORT_E), total: 0 errors, 9 warnings, 0 checks, 728 lines checked 589b6c2dd52b drm/i915: add LNL PCI IDs -:23: ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses #23: FILE: include/drm/i915_pciids.h:787: +#define INTEL_LNL_IDS(MACRO__, ...) \ + MACRO__(0x6420, ## __VA_ARGS__), \ + MACRO__(0x64A0, ## __VA_ARGS__), \ + MACRO__(0x64B0, ## __VA_ARGS__) -:23: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'MACRO__' - possible side-effects? #23: FILE: include/drm/i915_pciids.h:787: +#define INTEL_LNL_IDS(MACRO__, ...) \ + MACRO__(0x6420, ## __VA_ARGS__), \ + MACRO__(0x64A0, ## __VA_ARGS__), \ + MACRO__(0x64B0, ## __VA_ARGS__) total: 1 errors, 0 warnings, 1 checks, 10 lines checked 71eb16357c7d drm/i915/display: change display probe to identify GMD ID based platforms -:109: ERROR:CODE_INDENT: code indent should use tabs where possible #109: FILE: drivers/gpu/drm/i915/display/intel_display_device.c:1044: + if (!info)$ -:109: WARNING:LEADING_SPACE: please, no spaces at the start of a line #109: FILE: drivers/gpu/drm/i915/display/intel_display_device.c:1044: + if (!info)$ total: 1 errors, 1 warnings, 0 checks, 89 lines checked 8839f6e91bef drm/i915/display: identify platforms with enum and name d695d60f1e8c drm/i915/display: add support for subplatforms 241f1aaa977b drm/i915/display: add probe message