> -----Original Message-----
> From: Hogander, Jouni <jouni.hogander@xxxxxxxxx>
> Sent: Monday, May 27, 2024 12:52 PM
> To: intel-gfx@xxxxxxxxxxxxxxxxxxxxx
> Cc: Manna, Animesh <animesh.manna@xxxxxxxxx>; Kahola, Mika
> <mika.kahola@xxxxxxxxx>; Hogander, Jouni <jouni.hogander@xxxxxxxxx>
> Subject: [PATCH v3 03/20] drm/i915/psr: Move printing sink PSR support to
> own function
>
> intel_psr_status has grown and is about to grow even. Let's split it a bit and
> move printing sink psr support to an own function.
>
> Signed-off-by: Jouni Högander <jouni.hogander@xxxxxxxxx>
Reviewed-by: Animesh Manna <animesh.manna@xxxxxxxxx>
> ---
> drivers/gpu/drm/i915/display/intel_psr.c | 22 +++++++++++++++-------
> 1 file changed, 15 insertions(+), 7 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/display/intel_psr.c
> b/drivers/gpu/drm/i915/display/intel_psr.c
> index 08d3c8c81585..943de3ca39c2 100644
> --- a/drivers/gpu/drm/i915/display/intel_psr.c
> +++ b/drivers/gpu/drm/i915/display/intel_psr.c
> @@ -3590,15 +3590,10 @@ psr_source_status(struct intel_dp *intel_dp,
> struct seq_file *m)
> seq_printf(m, "Source PSR/PanelReplay status: %s [0x%08x]\n",
> status, val); }
>
> -static int intel_psr_status(struct seq_file *m, struct intel_dp *intel_dp)
> +static void intel_psr_sink_capability(struct intel_dp *intel_dp,
> + struct seq_file *m)
> {
> - struct drm_i915_private *dev_priv = dp_to_i915(intel_dp);
> - enum transcoder cpu_transcoder = intel_dp->psr.transcoder;
> struct intel_psr *psr = &intel_dp->psr;
> - intel_wakeref_t wakeref;
> - const char *status;
> - bool enabled;
> - u32 val;
>
> seq_printf(m, "Sink support: PSR = %s",
> str_yes_no(psr->sink_support));
> @@ -3608,6 +3603,19 @@ static int intel_psr_status(struct seq_file *m,
> struct intel_dp *intel_dp)
> seq_printf(m, ", Panel Replay = %s", str_yes_no(psr-
> >sink_panel_replay_support));
> seq_printf(m, ", Panel Replay Selective Update = %s\n",
> str_yes_no(psr->sink_panel_replay_su_support));
> +}
> +
> +static int intel_psr_status(struct seq_file *m, struct intel_dp
> +*intel_dp) {
> + struct drm_i915_private *dev_priv = dp_to_i915(intel_dp);
> + enum transcoder cpu_transcoder = intel_dp->psr.transcoder;
> + struct intel_psr *psr = &intel_dp->psr;
> + intel_wakeref_t wakeref;
> + const char *status;
> + bool enabled;
> + u32 val;
> +
> + intel_psr_sink_capability(intel_dp, m);
>
> if (!(psr->sink_support || psr->sink_panel_replay_support))
> return 0;
> --
> 2.34.1
