On Mon, 2024-05-27 at 13:56 +0530, Animesh Manna wrote: > Link Off Between Active Frames (LOBF) allows an eDP link to be turned > Off and On > durning long VBLANK durations without enabling any of the PSR/PSR2/PR > modes of operation. > > Bspec: 71477 > > Note: Lobf need to be enabled adaptive sync fixed refresh mode > where vmin = vmax = flipline, which will arise after cmmr feature > enablement. Currently existing code refactored and make compute- > config() > and enabling function ready. Will add enabling sequence in a separate > patch. For the whole set: Reviewed-by: Jouni Högander <jouni.hogander@xxxxxxxxx> Couple of points that needs some attention later: PSR code should move to use intel_alpm_aux_wake_supported and intel_alpm_aux_less_wake_supported rather than read DP_RECEIVER_ALPM_CAP again. I will probably take care of this in my Panel Replay eDP patch set. We could have common intel_alpm_compute_config which would calculate alpm_params. Then common intel_alpm_configure call for both PSR and LOBF which would write what is computed in intel_alpm_compute_config, intel_alpm_lobf_compute_config and intel_psr_compute_config. BR, Jouni Högander > > Signed-off-by: Animesh Manna <animesh.manna@xxxxxxxxx> > > Animesh Manna (5): > drm/i915/alpm: Move alpm parameters from intel_psr > drm/i915/alpm: Move alpm related code to a new file > drm/i915/alpm: Add compute config for lobf > drm/i915/alpm: Enable lobf from source in ALPM_CTL > drm/i915/alpm: Add debugfs for LOBF > > Jouni Högander (1): > drm/display: Add missing aux less alpm wake related bits > > drivers/gpu/drm/i915/Makefile | 1 + > drivers/gpu/drm/i915/display/intel_alpm.c | 411 > ++++++++++++++++++ > drivers/gpu/drm/i915/display/intel_alpm.h | 25 ++ > .../drm/i915/display/intel_display_debugfs.c | 2 + > .../drm/i915/display/intel_display_types.h | 26 +- > drivers/gpu/drm/i915/display/intel_dp.c | 4 + > drivers/gpu/drm/i915/display/intel_psr.c | 303 +------------ > drivers/gpu/drm/xe/Makefile | 1 + > include/drm/display/drm_dp.h | 5 +- > 9 files changed, 475 insertions(+), 303 deletions(-) > create mode 100644 drivers/gpu/drm/i915/display/intel_alpm.c > create mode 100644 drivers/gpu/drm/i915/display/intel_alpm.h >
