On Tue, Oct 22, 2013 at 12:30:11AM +0200, Daniel Vetter wrote: > On Mon, Oct 21, 2013 at 7:35 PM, Ben Widawsky > <benjamin.widawsky@xxxxxxxxx> wrote: > > Many GENs generally perform the same actions just on different > > registers. This is true going forward as well. To ease the transition a > > bit, extract the common code where possible. > > > > Signed-off-by: Ben Widawsky <ben@xxxxxxxxxxxx> > > Imo we should just switch to vtables or something like that, since > it's not just the register that changes, but also the meaning of the > different bits in the registers themselves and the logic to drive > stuff. We've often had regression-galore in this code and strictly > separating different platforms should help. I hope. > -Daniel I do not disagree. I have neither the skill, time, not inclination to do that properly, and I really only care about patch 2. The cleanup here makes the next patch slightly nicer, but I can live with whatever. -- Ben Widawsky, Intel Open Source Technology Center _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx http://lists.freedesktop.org/mailman/listinfo/intel-gfx
