On Mon, Oct 21, 2013 at 7:35 PM, Ben Widawsky <benjamin.widawsky@xxxxxxxxx> wrote: > Many GENs generally perform the same actions just on different > registers. This is true going forward as well. To ease the transition a > bit, extract the common code where possible. > > Signed-off-by: Ben Widawsky <ben@xxxxxxxxxxxx> Imo we should just switch to vtables or something like that, since it's not just the register that changes, but also the meaning of the different bits in the registers themselves and the logic to drive stuff. We've often had regression-galore in this code and strictly separating different platforms should help. I hope. -Daniel -- Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx http://lists.freedesktop.org/mailman/listinfo/intel-gfx