This is v2 of [1], addressing the feedback comments from Jani and Ville: - Use a more generic 'link' substruct instead of 'link_train'. (Patch 2) - Add the debugfs entries from intel_dp_link_training.c . (Patch 17-21) - Add the link state check work to intel_digital_port instead of intel_dp, to allow using it later for HDMI. (Patch 7) - Keep using the atomic state to look up MST connectors, avoiding the access to any object's current state. (Patch 9) - Add a separate debugfs entry to get the max link rate/lane count. (Patch 18) [1] https://lore.kernel.org/all/20240514191418.2863344-1-imre.deak@xxxxxxxxx Cc: Jani Nikula <jani.nikula@xxxxxxxxx> Cc: Ville Syrjälä <ville.syrjala@xxxxxxxxxxxxxxx> Imre Deak (21): drm/i915/dp_mst: Align TUs to avoid splitting symbols across MTPs drm/i915/dp: Move link train params to a substruct in intel_dp drm/i915/dp: Move link train fallback to intel_dp_link_training.c drm/i915/dp: Sanitize intel_dp_get_link_train_fallback_values() drm/i915: Factor out function to modeset commit a set of pipes drm/i915/dp: Use a commit modeset for link retraining MST links drm/i915/dp: Recheck link state after modeset drm/i915/dp: Reduce link params only after retrying with unchanged params drm/i915/dp: Pass atomic state to link training function drm/i915/dp: Send a link training modeset-retry uevent to all MST connectors drm/i915/dp: Use check link state work in the hotplug handler drm/i915/dp: Use check link state work in the detect handler drm/i915/dp: Use check link state work in the HPD IRQ handler drm/i915/dp: Disable link retraining after the last fallback step drm/i915/dp_mst: Reset intel_dp->link_trained during disabling drm/i915/dp_mst: Enable link training fallback for MST drm/i915/dp: Add debugfs entries to set a target link rate/lane count drm/i915/dp: Add debugfs entries to get the max link rate/lane count drm/i915/dp: Add debugfs entry to force link training failure drm/i915/dp: Add debugfs entry to force link retrain drm/i915/dp: Add debugfs entry for link training info drivers/gpu/drm/i915/display/g4x_dp.c | 29 +- drivers/gpu/drm/i915/display/intel_ddi.c | 64 +- drivers/gpu/drm/i915/display/intel_ddi.h | 4 + drivers/gpu/drm/i915/display/intel_display.c | 34 ++ drivers/gpu/drm/i915/display/intel_display.h | 3 + .../drm/i915/display/intel_display_debugfs.c | 2 + .../drm/i915/display/intel_display_types.h | 26 +- drivers/gpu/drm/i915/display/intel_dp.c | 241 ++++---- drivers/gpu/drm/i915/display/intel_dp.h | 8 +- .../drm/i915/display/intel_dp_link_training.c | 545 +++++++++++++++++- .../drm/i915/display/intel_dp_link_training.h | 8 +- drivers/gpu/drm/i915/display/intel_dp_mst.c | 30 +- 12 files changed, 805 insertions(+), 189 deletions(-) -- 2.43.3
