On Fri, 10 May 2024, Jani Nikula <jani.nikula@xxxxxxxxx> wrote:
> The xe->enabled_irq_mask member has never been used for anything.
>
> Signed-off-by: Jani Nikula <jani.nikula@xxxxxxxxx>
Lucas, ack for merging these two via drm-intel-next? Even though these
touch struct xe_device, I presume any further cleanups touching the
surrounding context would have a bigger footprint in drm-intel-next.
BR,
Jani.
> ---
> drivers/gpu/drm/xe/display/xe_display.c | 1 -
> drivers/gpu/drm/xe/xe_device_types.h | 2 --
> 2 files changed, 3 deletions(-)
>
> diff --git a/drivers/gpu/drm/xe/display/xe_display.c b/drivers/gpu/drm/xe/display/xe_display.c
> index 0de0566e5b39..fbe2c2eddea9 100644
> --- a/drivers/gpu/drm/xe/display/xe_display.c
> +++ b/drivers/gpu/drm/xe/display/xe_display.c
> @@ -97,7 +97,6 @@ int xe_display_create(struct xe_device *xe)
> xe->display.hotplug.dp_wq = alloc_ordered_workqueue("xe-dp", 0);
>
> drmm_mutex_init(&xe->drm, &xe->sb_lock);
> - xe->enabled_irq_mask = ~0;
>
> return drmm_add_action_or_reset(&xe->drm, display_destroy, NULL);
> }
> diff --git a/drivers/gpu/drm/xe/xe_device_types.h b/drivers/gpu/drm/xe/xe_device_types.h
> index 906b98fb973b..b78223e3baab 100644
> --- a/drivers/gpu/drm/xe/xe_device_types.h
> +++ b/drivers/gpu/drm/xe/xe_device_types.h
> @@ -517,8 +517,6 @@ struct xe_device {
> /* only to allow build, not used functionally */
> u32 irq_mask;
>
> - u32 enabled_irq_mask;
> -
> struct intel_uncore {
> spinlock_t lock;
> } uncore;
--
Jani Nikula, Intel
