On Thu, 09 May 2024, Rodrigo Vivi <rodrigo.vivi@xxxxxxxxx> wrote: > On Wed, May 08, 2024 at 06:47:50PM +0300, Jani Nikula wrote: >> Avoid the implicit dev_priv local variable use, and pass dev_priv >> explicitly to the TRANS_VRR_VMAXSHIFT register macro. >> >> Signed-off-by: Jani Nikula <jani.nikula@xxxxxxxxx> >> --- >> drivers/gpu/drm/i915/i915_reg.h | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/drivers/gpu/drm/i915/i915_reg.h b/drivers/gpu/drm/i915/i915_reg.h >> index 775c878ca72f..9739ef525e13 100644 >> --- a/drivers/gpu/drm/i915/i915_reg.h >> +++ b/drivers/gpu/drm/i915/i915_reg.h >> @@ -1261,7 +1261,7 @@ >> #define _TRANS_VRR_VMAXSHIFT_B 0x61428 >> #define _TRANS_VRR_VMAXSHIFT_C 0x62428 >> #define _TRANS_VRR_VMAXSHIFT_D 0x63428 >> -#define TRANS_VRR_VMAXSHIFT(trans) _MMIO_TRANS2(dev_priv, trans, \ >> +#define TRANS_VRR_VMAXSHIFT(dev_priv, trans) _MMIO_TRANS2(dev_priv, trans, \ > > unused? should we remove? > or one of those with wip around that is going to get used soon? > if so, VRR is new-ish, so I decided to keep these even though I don't know for sure that they will be used soon. > Reviewed-by: Rodrigo Vivi <rodrigo.vivi@xxxxxxxxx> Thanks for the review, series pushed to din. BR, Jani. > >> _TRANS_VRR_VMAXSHIFT_A) >> #define VRR_VMAXSHIFT_DEC_MASK REG_GENMASK(29, 16) >> #define VRR_VMAXSHIFT_DEC REG_BIT(16) >> -- >> 2.39.2 >> -- Jani Nikula, Intel
