On Mon, 06 May 2024, Ville Syrjälä <ville.syrjala@xxxxxxxxxxxxxxx> wrote: > On Mon, May 06, 2024 at 01:09:04PM +0300, Jani Nikula wrote: >> Avoid the implicit dev_priv local variable use, and pass dev_priv >> explicitly to the PORT_DFT2_G4X register macro. > > Looks like we only use this on VLV/CHV, so could define a fixed > offset _VLV variant. > > But this works too > Reviewed-by: Ville Syrjälä <ville.syrjala@xxxxxxxxxxxxxxx> Took the easy route and pushed them as-is, thanks for the review. BR, Jani. -- Jani Nikula, Intel