On Mon, May 06, 2024 at 07:51:47PM +0300, Ville Syrjälä wrote: > On Mon, May 06, 2024 at 05:16:50PM +0300, Jani Nikula wrote: > > > > *return in subject > > > > On Mon, 06 May 2024, Ville Syrjala <ville.syrjala@xxxxxxxxxxxxxxx> wrote: > > > From: Ville Syrjälä <ville.syrjala@xxxxxxxxxxxxxxx> > > > > > > Change intel_fbdev_fb_alloc() to return struct intel_fb instead > > > of struct drm_framebuffer. Let's us eliminate some annoying > > > aliasing variables in the fbdev setup code. > > > > You'll need to enable DRM_XE=m and DRM_XE_DISPLAY=y configs, this will > > fail the build there. ;) > > $ grep DRM_XE build_test/.config > CONFIG_DRM_XE=m > CONFIG_DRM_XE_DISPLAY=y > > It actually builds just fine here, which is a bit > surprising. And the reason seems to be that xe has its own copy of that header for some reason. So xe's intel_fbdev_fb.c will include the xe header, but everything in i915 will include the i915 header. The two could be talking about apples vs. oranges and the build would never fail :/ -- Ville Syrjälä Intel
