✗ Fi.CI.CHECKPATCH: warning for fs: Do not allow get_file() to resurrect 0 f_count

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



== Series Details ==

Series: fs: Do not allow get_file() to resurrect 0 f_count
URL   : https://patchwork.freedesktop.org/series/133157/
State : warning

== Summary ==

Error: dim checkpatch failed
05a74d02542d fs: Do not allow get_file() to resurrect 0 f_count
cb506a379959 drm/vmwgfx: Do not directly manipulate file->f_count
-:20: CHECK:COMPARISON_TO_NULL: Comparison to NULL could be written "get_file"
#20: FILE: drivers/gpu/drm/vmwgfx/ttm_object.c:474:
+	return get_file(dmabuf->file) != NULL;

total: 0 errors, 0 warnings, 1 checks, 8 lines checked
82672373ae1d drm/i915: Do not directly manipulate file->f_count
1f5237fd1d94 refcount: Introduce refcount_long_t and APIs
-:58: WARNING:FILE_PATH_CHANGES: added, moved or deleted file(s), does MAINTAINERS need updating?
#58: 
new file mode 100644

-:398: CHECK:AVOID_EXTERNS: extern prototypes should be avoided in .h files
#398: FILE: include/linux/refcount-impl.h:336:
+extern __must_check bool refcount_dec_if_one(refcount_t *r);

-:399: CHECK:AVOID_EXTERNS: extern prototypes should be avoided in .h files
#399: FILE: include/linux/refcount-impl.h:337:
+extern __must_check bool refcount_dec_not_one(refcount_t *r);

-:400: WARNING:LONG_LINE: line length of 110 exceeds 100 columns
#400: FILE: include/linux/refcount-impl.h:338:
+extern __must_check bool refcount_dec_and_mutex_lock(refcount_t *r, struct mutex *lock) __cond_acquires(lock);

-:400: CHECK:AVOID_EXTERNS: extern prototypes should be avoided in .h files
#400: FILE: include/linux/refcount-impl.h:338:
+extern __must_check bool refcount_dec_and_mutex_lock(refcount_t *r, struct mutex *lock) __cond_acquires(lock);

-:401: WARNING:LONG_LINE: line length of 102 exceeds 100 columns
#401: FILE: include/linux/refcount-impl.h:339:
+extern __must_check bool refcount_dec_and_lock(refcount_t *r, spinlock_t *lock) __cond_acquires(lock);

-:401: CHECK:AVOID_EXTERNS: extern prototypes should be avoided in .h files
#401: FILE: include/linux/refcount-impl.h:339:
+extern __must_check bool refcount_dec_and_lock(refcount_t *r, spinlock_t *lock) __cond_acquires(lock);

-:402: CHECK:AVOID_EXTERNS: extern prototypes should be avoided in .h files
#402: FILE: include/linux/refcount-impl.h:340:
+extern __must_check bool refcount_dec_and_lock_irqsave(refcount_t *r,

-:787: WARNING:NEW_TYPEDEFS: do not add new typedefs
#787: FILE: include/linux/refcount_types.h:27:
+typedef struct refcount_long_struct {

total: 0 errors, 4 warnings, 5 checks, 780 lines checked
7c03be650afd fs: Convert struct file::f_count to refcount_long_t





[Index of Archives]     [AMD Graphics]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux