On Tue, 23 Apr 2024, Ville Syrjälä <ville.syrjala@xxxxxxxxxxxxxxx> wrote: > On Mon, Apr 22, 2024 at 01:10:57PM +0300, Jani Nikula wrote: >> On Mon, 22 Apr 2024, Ville Syrjala <ville.syrjala@xxxxxxxxxxxxxxx> wrote: >> > diff --git a/drivers/gpu/drm/i915/vlv_sideband.c b/drivers/gpu/drm/i915/vlv_sideband.c >> > index ffa195560d0d..68291412f4cb 100644 >> > --- a/drivers/gpu/drm/i915/vlv_sideband.c >> > +++ b/drivers/gpu/drm/i915/vlv_sideband.c >> > @@ -9,7 +9,6 @@ >> > #include "vlv_sideband.h" >> > >> > #include "display/intel_dpio_phy.h" >> > -#include "display/intel_display_types.h" >> >> I guess this should be done in some other patch? > > I think it should have been part of > commit f70a68bc1d18 ("drm/i915: convert vlv_dpio_read()/write() from > pipe to phy") > > but got missed. This patch is basically what was left from a > similar change I had in my branch. I can split this hunk out > into a separate patch. No big deal, really. I just want to get this stuff merged. :) BR, Jani. -- Jani Nikula, Intel