On Mon, Apr 15, 2024 at 03:39:41PM +0300, Jani Nikula wrote: > On Fri, 12 Apr 2024, Ville Syrjala <ville.syrjala@xxxxxxxxxxxxxxx> wrote: > > From: Ville Syrjälä <ville.syrjala@xxxxxxxxxxxxxxx> > > > > Since all of this lives in intel_dpio_phy.c let's rename the > > bxt/glk functions to have bxt_dpio_phy_ namespace. > > Seems like intel_dpio_phy.c could be split to vlv_dpio_phy.c and > bxt_dpio_phy.c after this. At a glance, there isn't really anything > shared between VLV/CHV and BXT/GLK code paths. They've just been thrown > in to the same file. Yeah, the original idea was that we could perhaps combine the CHV and BXT/GLK code into one since it's the same IP block on both, but we ended up doing things a bit differently between the two anyway so probably no one will ever do this. VLV vs. CHV could also be split since the PHY codepaths are compleletely separate, but perhaps not really worth it since a lot of the other code is shared between the two platforms anyway. -- Ville Syrjälä Intel
