> -----Original Message----- > From: Ville Syrjälä <ville.syrjala@xxxxxxxxxxxxxxx> > Sent: Tuesday, April 16, 2024 6:25 PM > To: Kandpal, Suraj <suraj.kandpal@xxxxxxxxx> > Cc: intel-gfx@xxxxxxxxxxxxxxxxxxxxx; Borah, Chaitanya Kumar > <chaitanya.kumar.borah@xxxxxxxxx>; Shankar, Uma > <uma.shankar@xxxxxxxxx>; Nautiyal, Ankit K <ankit.k.nautiyal@xxxxxxxxx>; > Bhadane, Dnyaneshwar <dnyaneshwar.bhadane@xxxxxxxxx> > Subject: Re: [PATCH 1/2] drm/i915: Add SCLKGATE_DIS register definition > > On Tue, Apr 16, 2024 at 12:57:33PM +0530, Suraj Kandpal wrote: > > Add SCLKGATE_DIS register and it's register definition which will be > > used the next patch. > > > > Signed-off-by: Suraj Kandpal <suraj.kandpal@xxxxxxxxx> > > --- > > drivers/gpu/drm/i915/i915_reg.h | 4 ++++ > > 1 file changed, 4 insertions(+) > > > > diff --git a/drivers/gpu/drm/i915/i915_reg.h > > b/drivers/gpu/drm/i915/i915_reg.h index 3f34efcd7d6c..beec91a2f493 > > 100644 > > --- a/drivers/gpu/drm/i915/i915_reg.h > > +++ b/drivers/gpu/drm/i915/i915_reg.h > > @@ -6250,6 +6250,10 @@ enum skl_power_gate { > > #define SFUSE_STRAP_DDIC_DETECTED (1 << 1) > > #define SFUSE_STRAP_DDID_DETECTED (1 << 0) > > > > +/* SCLKGATE_DIS */ > > +#define SCLKGATE_DIS _MMIO(0xc2014) > > That address is SFUSE_STRAP > Hi Ville had noticed that fixed it along with Jani's other comments https://patchwork.freedesktop.org/series/132495/ Regards, Suraj Kandpal > > +#define DPLS_GATING_DISABLE REG_BIT(29) > > + > > #define WM_MISC _MMIO(0x45260) > > #define WM_MISC_DATA_PARTITION_5_6 (1 << 0) > > > > -- > > 2.43.2 > > -- > Ville Syrjälä > Intel