On Fri, 12 Apr 2024, Animesh Manna <animesh.manna@xxxxxxxxx> wrote: > Set the Link Off Between Frames Enable bit in ALPM_CTL register. > > Signed-off-by: Animesh Manna <animesh.manna@xxxxxxxxx> > --- > drivers/gpu/drm/i915/display/intel_alpm.c | 5 +++++ > drivers/gpu/drm/i915/display/intel_display_types.h | 1 + > 2 files changed, 6 insertions(+) > > diff --git a/drivers/gpu/drm/i915/display/intel_alpm.c b/drivers/gpu/drm/i915/display/intel_alpm.c > index 699f2f051766..ae894c85233c 100644 > --- a/drivers/gpu/drm/i915/display/intel_alpm.c > +++ b/drivers/gpu/drm/i915/display/intel_alpm.c > @@ -325,6 +325,11 @@ static void lnl_alpm_configure(struct intel_dp *intel_dp) > ALPM_CTL_EXTENDED_FAST_WAKE_TIME(intel_dp->alpm_parameters.fast_wake_lines); > } > > + if (intel_dp->lobf_supported) { > + alpm_ctl |= ALPM_CTL_LOBF_ENABLE; > + intel_dp->lobf_enabled = true; Gut feeling says this should not be part of intel_dp but rather crtc state. BR, Jani. > + } > + > alpm_ctl |= ALPM_CTL_ALPM_ENTRY_CHECK(intel_dp->alpm_parameters.check_entry_lines); > > intel_de_write(dev_priv, ALPM_CTL(cpu_transcoder), alpm_ctl); > diff --git a/drivers/gpu/drm/i915/display/intel_display_types.h b/drivers/gpu/drm/i915/display/intel_display_types.h > index 6116c383b543..f61ba582429b 100644 > --- a/drivers/gpu/drm/i915/display/intel_display_types.h > +++ b/drivers/gpu/drm/i915/display/intel_display_types.h > @@ -1884,6 +1884,7 @@ struct intel_dp { > > /* LOBF flags*/ > bool lobf_supported; > + bool lobf_enabled; > }; > > enum lspcon_vendor { -- Jani Nikula, Intel