Framebuffer format modifiers are used to indicate the existence of
auxillary surface in the plane, containing the CCS data. But on
Xe2_HPD, the CCS data is stored in a fixed reserved memory area and not
part of the plane. It contains no auxillary surface.
Also in Xe2, the compression is configured via PAT settings in the
pagetable mappings. Decompression is enabled by default in the
PLANE_CTL. Based on whether valid CCS data exists for the plane, display
hardware decides whether compression is necessary or not.
So there is no need for format modifiers to indicate if compression is
enabled or not.
v2:
* Improved the commit description with more details
* Removed the redundant display IP version check for 20. Display version
check for each modifier above would take care of it.
CC: Juha-Pekka Heikkilä <juha-pekka.heikkila@xxxxxxxxx>
CC: Matt Roper <matthew.d.roper@xxxxxxxxx>
Signed-off-by: Balasubramani Vivekanandan <balasubramani.vivekanandan@xxxxxxxxx>
---
drivers/gpu/drm/i915/display/intel_fb.c | 16 +++++++++++++---
1 file changed, 13 insertions(+), 3 deletions(-)
diff --git a/drivers/gpu/drm/i915/display/intel_fb.c b/drivers/gpu/drm/i915/display/intel_fb.c
index 86b443433e8b..7234ce36b6a4 100644
--- a/drivers/gpu/drm/i915/display/intel_fb.c
+++ b/drivers/gpu/drm/i915/display/intel_fb.c
@@ -431,9 +431,19 @@ static bool plane_has_modifier(struct drm_i915_private *i915,
* Separate AuxCCS and Flat CCS modifiers to be run only on platforms
* where supported.
*/
- if (intel_fb_is_ccs_modifier(md->modifier) &&
- HAS_FLAT_CCS(i915) != !md->ccs.packed_aux_planes)
- return false;
+ if (intel_fb_is_ccs_modifier(md->modifier)) {
+
+ /*
+ * There is no need for CCS format modifiers for Xe2_HPD, as
+ * there is no support of AuxCCS and the FlatCCS is configured
+ * usign PAT index in the page table mappings
+ */
+ if (DISPLAY_VER_FULL(i915) == IP_VER(14, 1))
+ return false;
+
+ if (HAS_FLAT_CCS(i915) != !md->ccs.packed_aux_planes)
+ return false;
+ }
return true;
}
--
2.25.1
