On Fri, 12 Apr 2024, Ville Syrjälä <ville.syrjala@xxxxxxxxxxxxxxx> wrote: > On Fri, Apr 12, 2024 at 05:52:55PM +0300, Jani Nikula wrote: >> +/* >> + * Framebuffer compression (915+ only) >> + */ > > Outdated comment. Looks like pretty much all the comments > in this file are misleading/outdated. Maybe just nuke them > all while at it. Ack. >> +#define ILK_DISPLAY_CHICKEN1 _MMIO(0x42000) > > Not an FBC register. Whoops, this one was an accident. >> +#define CHICKEN_MISC_4 _MMIO(0x4208c) > > Also not an FBC register. However this one was intentional. So the register isn't "an fbc register", but the contents are all about fbc, and it's only used in intel_fbc.c. I guess after all reasonable topical things have been split out from i915_reg.h, whatever display stuff is left will need to be put to a new intel_display_regs.h or something. Things like this would then end up there. Better or worse that way, I don't know. BR, Jani. -- Jani Nikula, Intel
