RE: [PATCH 01/13] spi: add auxiliary device for intel dg spi

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



> -----Original Message-----
> From: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx>
> Sent: Friday, March 29, 2024 15:47
> To: Usyskin, Alexander <alexander.usyskin@xxxxxxxxx>; Miquel Raynal
> <miquel.raynal@xxxxxxxxxxx>; Richard Weinberger <richard@xxxxxx>; Vignesh
> Raghavendra <vigneshr@xxxxxx>; Jani Nikula <jani.nikula@xxxxxxxxxxxxxxx>;
> Joonas Lahtinen <joonas.lahtinen@xxxxxxxxxxxxxxx>; Vivi, Rodrigo
> <rodrigo.vivi@xxxxxxxxx>
> Cc: Lubart, Vitaly <vitaly.lubart@xxxxxxxxx>; linux-mtd@xxxxxxxxxxxxxxxxxxx; intel-
> gfx@xxxxxxxxxxxxxxxxxxxxx
> Subject: Re: [PATCH 01/13] spi: add auxiliary device for intel dg spi
> 
> On 28/03/2024 13:22, Alexander Usyskin wrote:
> > Add auxilary bus device structure for
> > Intel Discrete Graphics SPI device.
> >
> > Signed-off-by: Alexander Usyskin <alexander.usyskin@xxxxxxxxx>
> > ---
> >  include/linux/intel_dg_spi_aux.h | 27 +++++++++++++++++++++++++++
> 
> There is no user of this header. Please add it in the patch which uses it.
> 
This header describes auxiliary device that bridges between
i915 or Xe driver with spi-intel-dg driver.
This header included in both drivers; this is the reason this header
has its own patch.

> It will also justify why you use this or other subject prefix. Now, it
> looks just wrong: it's not a patch for spi.
> 
Can you suggest what subject prefix to use?
Like: "auxiliary:"? Something else?

> If it was a patch for spi, then:
> 
> Please use scripts/get_maintainers.pl to get a list of necessary people
> and lists to CC (and consider --no-git-fallback argument). It might
> happen, that command when run on an older kernel, gives you outdated
> entries. Therefore please be sure you base your patches on recent Linux
> kernel.
> 
Sorry for that, will run this script to pick the fresh maintainers list and
push v2 with a new list.


> Best regards,
> Krzysztof

-- 
Thanks,
Sasha






[Index of Archives]     [AMD Graphics]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux