On Fri, 05 Apr 2024, Ville Syrjälä <ville.syrjala@xxxxxxxxxxxxxxx> wrote: > On Fri, Apr 05, 2024 at 10:45:42AM +0200, Thomas Zimmermann wrote: >> Am 07.03.24 um 21:39 schrieb Jani Nikula: >> > +void drm_mode_print(struct drm_printer *p, const struct drm_display_mode *mode) >> >> Could this be a printf function with a trailing format string as final >> argument? The printed mode could then be part of another string instead >> of just at the end of it. > > All this seems pretty much redundant. We already have > DRM_MODE_FMT/ARGS so people can include the mode in any > kind of format string they want. > > I would just nuke drm_mode_print() and all its ilk and > let people format things themselves. Fair enough. Did just that in v2, for all the non-driver stuff anyway. BR, Jani. -- Jani Nikula, Intel
