Forgot to add my Rb
Reviewed-by: Arun R Murthy <arun.r.mruthy@xxxxxxxxx>
Thanks and Regards,
Arun R Murthy
--------------------
> -----Original Message-----
> From: Murthy, Arun R
> Sent: Friday, April 5, 2024 6:30 PM
> To: Hogander, Jouni <jouni.hogander@xxxxxxxxx>; ville.syrjala@xxxxxxxxxxxxxxx;
> intel-gfx@xxxxxxxxxxxxxxxxxxxxx
> Subject: RE: [PATCH v2 02/17] drm/i915/psr: Disable PSR when bigjoiner is used
>
>
>
> > -----Original Message-----
> > From: Intel-gfx <intel-gfx-bounces@xxxxxxxxxxxxxxxxxxxxx> On Behalf Of
> > Hogander, Jouni
> > Sent: Friday, April 5, 2024 12:29 PM
> > To: ville.syrjala@xxxxxxxxxxxxxxx; intel-gfx@xxxxxxxxxxxxxxxxxxxxx
> > Subject: Re: [PATCH v2 02/17] drm/i915/psr: Disable PSR when bigjoiner
> > is used
> >
> > On Fri, 2024-04-05 at 00:34 +0300, Ville Syrjala wrote:
> > > From: Ville Syrjälä <ville.syrjala@xxxxxxxxxxxxxxx>
> > >
> > > Bigjoiner seem to be causing all kinds of grief to the PSR code
> > > currently. I don't believe there is any hardware issue but the code
> > > simply not handling this correctly. For now just disable PSR when
> > > bigjoiner is needed.
> > >
> > > Signed-off-by: Ville Syrjälä <ville.syrjala@xxxxxxxxxxxxxxx>
> > > ---
> > > drivers/gpu/drm/i915/display/intel_psr.c | 11 +++++++++++
> > > 1 file changed, 11 insertions(+)
> > >
> > > diff --git a/drivers/gpu/drm/i915/display/intel_psr.c
> > > b/drivers/gpu/drm/i915/display/intel_psr.c
> > > index eef62983e9db..a3ff916b53f9 100644
> > > --- a/drivers/gpu/drm/i915/display/intel_psr.c
> > > +++ b/drivers/gpu/drm/i915/display/intel_psr.c
> > > @@ -1584,6 +1584,17 @@ void intel_psr_compute_config(struct intel_dp
> > > *intel_dp,
> > > return;
> > > }
> > >
> > > + /*
> > > + * FIXME figure out what is wrong with PSR+bigjoiner and
> > > + * fix it. Presumably something related to the fact that
> > > + * PSR is a transcoder level feature.
> > > + */
> > > + if (crtc_state->bigjoiner_pipes) {
> > > + drm_dbg_kms(&dev_priv->drm,
> > > + "PSR disabled due to bigjoiner\n");
> > > + return;
> > > + }
> > > +
> >
> > Are these problems with both PSR1 and PSR2?
>
> Yes, as per the code this would have impact on both PSR1 and PSR2. So better
> to disable.
> Looks good to me.
>
> Thanks and Regards,
> Arun R Murthy
> --------------------
> >
> > BR,
> >
> > Jouni Högander
> >
> > > if (CAN_PANEL_REPLAY(intel_dp))
> > > crtc_state->has_panel_replay = true;
> > > else
