== Series Details == Series: drm/i915: Bigjoiner modeset sequence redesign and MST support (rev2) URL : https://patchwork.freedesktop.org/series/131797/ State : warning == Summary == Error: dim checkpatch failed f817bfecf2ae drm/i915: Update pipes in reverse order for bigjoiner -:86: CHECK:MACRO_ARG_REUSE: Macro argument reuse '__state' - possible side-effects? #86: FILE: drivers/gpu/drm/i915/display/intel_display.h:347: +#define for_each_new_intel_crtc_in_state_reverse(__state, crtc, new_crtc_state, __i) \ + for ((__i) = (__state)->base.dev->mode_config.num_crtc - 1; \ + (__i) >= 0 && \ + ((crtc) = to_intel_crtc((__state)->base.crtcs[__i].ptr), \ + (new_crtc_state) = to_intel_crtc_state((__state)->base.crtcs[__i].new_state), 1); \ + (__i)--) \ + for_each_if(crtc) -:86: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'crtc' - possible side-effects? #86: FILE: drivers/gpu/drm/i915/display/intel_display.h:347: +#define for_each_new_intel_crtc_in_state_reverse(__state, crtc, new_crtc_state, __i) \ + for ((__i) = (__state)->base.dev->mode_config.num_crtc - 1; \ + (__i) >= 0 && \ + ((crtc) = to_intel_crtc((__state)->base.crtcs[__i].ptr), \ + (new_crtc_state) = to_intel_crtc_state((__state)->base.crtcs[__i].new_state), 1); \ + (__i)--) \ + for_each_if(crtc) -:86: CHECK:MACRO_ARG_REUSE: Macro argument reuse '__i' - possible side-effects? #86: FILE: drivers/gpu/drm/i915/display/intel_display.h:347: +#define for_each_new_intel_crtc_in_state_reverse(__state, crtc, new_crtc_state, __i) \ + for ((__i) = (__state)->base.dev->mode_config.num_crtc - 1; \ + (__i) >= 0 && \ + ((crtc) = to_intel_crtc((__state)->base.crtcs[__i].ptr), \ + (new_crtc_state) = to_intel_crtc_state((__state)->base.crtcs[__i].new_state), 1); \ + (__i)--) \ + for_each_if(crtc) total: 0 errors, 0 warnings, 3 checks, 40 lines checked 1c096c7c7f11 drm/i915/psr: Disable PSR when bigjoiner is used 92634f79c716 drm/i915: Disable port sync when bigjoiner is used 5ccab6f2d622 drm/i915: Disable live M/N updates when using bigjoiner 4c078f970c6d drm/i915/vrr: Disable VRR when using bigjoiner b5c1397ace26 drm/i915: Fix intel_modeset_pipe_config_late() for bigjoiner 475267775ae9 drm/i915: s/intel_dp_can_bigjoiner()/intel_dp_has_bigjoiner()/ 3a923fd6f3c7 drm/i915: Extract intel_dp_joiner_needs_dsc() cda03d83a42d drm/i915/mst: Check intel_dp_joiner_needs_dsc() 8f9d67357dbc drm/i915: Pass connector to intel_dp_need_bigjoiner() 5d9d0c9c8d82 drm/i915: Introduce intel_crtc_joined_pipe_mask() 32258cb98972 drm/i915: Extract intel_ddi_post_disable_hdmi_or_sst() a553727cc947 drm/i915: Utilize intel_crtc_joined_pipe_mask() more ae82df63aaca drm/i915: Handle joined pipes inside hsw_crtc_disable() 657f77a42177 drm/i915: Handle joined pipes inside hsw_crtc_enable() -:11: WARNING:COMMIT_LOG_LONG_LINE: Prefer a maximum 75 chars per line (possible unwrapped commit description?) #11: That way we can also remove a bunch of checks like intel_crtc_is_bigjoiner_slave. -:320: ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses #320: FILE: drivers/gpu/drm/i915/display/intel_display.h:283: +#define for_each_intel_crtc_in_pipe_mask_reverse(dev, intel_crtc, pipe_mask) \ + list_for_each_entry_reverse((intel_crtc), \ + &(dev)->mode_config.crtc_list, \ + base.head) \ + for_each_if((pipe_mask) & BIT((intel_crtc)->pipe)) -:320: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'intel_crtc' - possible side-effects? #320: FILE: drivers/gpu/drm/i915/display/intel_display.h:283: +#define for_each_intel_crtc_in_pipe_mask_reverse(dev, intel_crtc, pipe_mask) \ + list_for_each_entry_reverse((intel_crtc), \ + &(dev)->mode_config.crtc_list, \ + base.head) \ + for_each_if((pipe_mask) & BIT((intel_crtc)->pipe)) total: 1 errors, 1 warnings, 1 checks, 275 lines checked 9c057ae8d3d2 drm/i915/mst: Add bigjoiner handling to MST modeset sequence 780db11dbe03 drm/i915: Allow bigjoiner for MST
