On Thu, 2024-03-28 at 05:33 +0000, Manna, Animesh wrote: > > > > -----Original Message----- > > From: Hogander, Jouni <jouni.hogander@xxxxxxxxx> > > Sent: Friday, March 22, 2024 4:00 PM > > To: intel-gfx@xxxxxxxxxxxxxxxxxxxxx > > Cc: Ville Syrjälä <ville.syrjala@xxxxxxxxxxxxxxx>; Manna, Animesh > > <animesh.manna@xxxxxxxxx>; Murthy, Arun R > > <arun.r.murthy@xxxxxxxxx>; > > Hogander, Jouni <jouni.hogander@xxxxxxxxx> > > Subject: [PATCH v5 0/5] ALPM AUX-Less > > > > This patch set is implementing calculation of ALPM AUX-Less > > parameters for > > Intel HW and writing them in case of AUX-Less is enabled. It is > > also enabling > > ALPM AUX-Less for eDP Panel Replay. Current code is not allowing > > Panel > > Replay on eDP. Patches for this are coming later. > > > > This implementation is only for Panel Replay usage. LOBF (Link Off > > Between > > Active Frames) usage needs more work. > > > > v5: > > - mention AUX Less enable is only on source side in commit > > message > > v4: > > - drop patch adding AUX LESS dpcd defines > > - re-use fast_wake_lines to store aux_less_wake_lines > > - add comment explaining why AUX less is enabled on eDP panel > > replay > > without any extra checks > > v3: > > - use definitions instead of numbers for max values > > - do not use alpm_ctl as uninitialized variable > > v2: > > - use variables instead of values directly > > - fix several max values > > - move converting port clock to Mhz into _lnl_compute_* > > - do not set AUX-Wake related bits for AUX-Less case > > - do not write ALPM configuration for DP2.0 Panel Replay or PSR1 > > > > Jouni Högander (5): > > drm/i915/psr: Add missing ALPM AUX-Less register definitions > > drm/i915/psr: Calculate aux less wake time > > drm/i915/psr: Silence period and lfps half cycle > > drm/i915/psr: Enable ALPM on source side for eDP Panel replay > > drm/i915/psr: Do not write ALPM configuration for PSR1 or DP2.0 > > Panel > > Replay > > The above patches LGTM. For whole patch series: > Reviewed-by: Animesh Manna <animesh.manna@xxxxxxxxx> Thank you Animesh for your review. There are now pushed to drm-intel- next. BR, Jouni Högander > > > > > .../drm/i915/display/intel_display_types.h | 2 + > > drivers/gpu/drm/i915/display/intel_psr.c | 188 > > +++++++++++++++++- > > drivers/gpu/drm/i915/display/intel_psr_regs.h | 12 +- > > 3 files changed, 193 insertions(+), 9 deletions(-) > > > > -- > > 2.34.1 >
