On Fri, 22 Mar 2024, Lucas De Marchi <lucas.demarchi@xxxxxxxxx> wrote: > oh, now I understand. You mean that xe module doesn't have the param > because it's only declared in drivers/gpu/drm/i915/i915_params.c. > > Could you extend the commit message with something like this? > > The dmc_firmware_path parameter is clearly a display parameter. Move it > there so it's available to both i915 and xe modules .... > > thanks > Reviewed-by: Lucas De Marchi <lucas.demarchi@xxxxxxxxx> Thanks for the review, pushed to drm-intel-next with an amended commit message. BR, Jani. -- Jani Nikula, Intel