Re: [PATCH 2/2] drm/i915/hdcp: Fix get remote hdcp capability function

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Suraj,

kernel test robot noticed the following build warnings:

[auto build test WARNING on drm-intel/for-linux-next]
[also build test WARNING on drm-intel/for-linux-next-fixes drm-tip/drm-tip linus/master v6.9-rc2 next-20240328]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Suraj-Kandpal/drm-i915-display-Initialize-capability-variables/20240401-110451
base:   git://anongit.freedesktop.org/drm-intel for-linux-next
patch link:    https://lore.kernel.org/r/20240401030106.274787-3-suraj.kandpal%40intel.com
patch subject: [PATCH 2/2] drm/i915/hdcp: Fix get remote hdcp capability function
config: arm-randconfig-001-20240401 (https://download.01.org/0day-ci/archive/20240401/202404011741.3ktdUlWv-lkp@xxxxxxxxx/config)
compiler: clang version 14.0.6 (https://github.com/llvm/llvm-project.git f28c006a5895fc0e329fe15fead81e37457cb1d1)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240401/202404011741.3ktdUlWv-lkp@xxxxxxxxx/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@xxxxxxxxx>
| Closes: https://lore.kernel.org/oe-kbuild-all/202404011741.3ktdUlWv-lkp@xxxxxxxxx/

All warnings (new ones prefixed by >>):

>> drivers/gpu/drm/i915/display/intel_dp_hdcp.c:697:17: warning: expression which evaluates to zero treated as a null pointer constant of type 'bool *' (aka '_Bool *') [-Wnon-literal-null-conversion]
           hdcp_capable = false;
                          ^~~~~
   drivers/gpu/drm/i915/display/intel_dp_hdcp.c:698:18: warning: expression which evaluates to zero treated as a null pointer constant of type 'bool *' (aka '_Bool *') [-Wnon-literal-null-conversion]
           hdcp2_capable = false;
                           ^~~~~
   2 warnings generated.


vim +697 drivers/gpu/drm/i915/display/intel_dp_hdcp.c

   683	
   684	static
   685	int intel_dp_hdcp_get_remote_capability(struct intel_connector *connector,
   686						bool *hdcp_capable,
   687						bool *hdcp2_capable)
   688	{
   689		struct drm_i915_private *i915 = to_i915(connector->base.dev);
   690		struct drm_dp_aux *aux = &connector->port->aux;
   691		u8 bcaps;
   692		int ret;
   693	
   694		if (!intel_encoder_is_mst(connector->encoder))
   695			return -EINVAL;
   696	
 > 697		hdcp_capable = false;
   698		hdcp2_capable = false;
   699		ret =  _intel_dp_hdcp2_get_capability(aux, hdcp2_capable);
   700		if (ret)
   701			drm_dbg_kms(&i915->drm,
   702				    "HDCP2 DPCD capability read failed err: %d\n", ret);
   703	
   704		ret = intel_dp_hdcp_read_bcaps(aux, i915, &bcaps);
   705		if (ret)
   706			return ret;
   707	
   708		*hdcp_capable = bcaps & DP_BCAPS_HDCP_CAPABLE;
   709	
   710		return 0;
   711	}
   712	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki



[Index of Archives]     [AMD Graphics]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux