> -----Original Message-----
> From: Intel-gfx <intel-gfx-bounces@xxxxxxxxxxxxxxxxxxxxx> On Behalf Of Ville
> Syrjala
> Sent: Friday, March 29, 2024 6:43 AM
> To: intel-gfx@xxxxxxxxxxxxxxxxxxxxx
> Subject: [PATCH 01/22] drm/i915: Disable port sync when bigjoiner is used
>
> From: Ville Syrjälä <ville.syrjala@xxxxxxxxxxxxxxx>
>
> The current modeset sequence can't handle port sync and bigjoiner at the
> same time. Refuse port sync when bigjoiner is needed, at least until we fix
> the modeset sequence.
>
> Signed-off-by: Ville Syrjälä <ville.syrjala@xxxxxxxxxxxxxxx>
Like you have said in the second patch in the series " port sync+bigjoiner would require a tiled display with >5k tiles (or a very high dotclock per tile)." this would be a rare case, since it needs to be fixed later, a todo comment would be helpful, to take care of it for later.
With that
Reviewed-by: Vandita Kulkarni <vandita.kulkarni@xxxxxxxxx>
> ---
> drivers/gpu/drm/i915/display/intel_ddi.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpu/drm/i915/display/intel_ddi.c
> b/drivers/gpu/drm/i915/display/intel_ddi.c
> index a3d3d4942eb1..fa6fe9ec8027 100644
> --- a/drivers/gpu/drm/i915/display/intel_ddi.c
> +++ b/drivers/gpu/drm/i915/display/intel_ddi.c
> @@ -4244,6 +4244,7 @@ static bool crtcs_port_sync_compatible(const
> struct intel_crtc_state *crtc_state
> const struct intel_crtc_state *crtc_state2)
> {
> return crtc_state1->hw.active && crtc_state2->hw.active &&
> + !crtc_state1->bigjoiner_pipes && !crtc_state2-
> >bigjoiner_pipes &&
> crtc_state1->output_types == crtc_state2->output_types &&
> crtc_state1->output_format == crtc_state2->output_format
> &&
> crtc_state1->lane_count == crtc_state2->lane_count &&
> --
> 2.43.2
