> -----Original Message-----
> From: Hogander, Jouni <jouni.hogander@xxxxxxxxx>
> Sent: Wednesday, March 6, 2024 4:15 PM
> To: intel-gfx@xxxxxxxxxxxxxxxxxxxxx
> Cc: Ville Syrjälä <ville.syrjala@xxxxxxxxxxxxxxx>; Manna, Animesh
> <animesh.manna@xxxxxxxxx>; Murthy, Arun R <arun.r.murthy@xxxxxxxxx>;
> Hogander, Jouni <jouni.hogander@xxxxxxxxx>
> Subject: [PATCH v3 6/6] drm/i915/psr: Do not write ALPM configuration for
> PSR1 or DP2.0 Panel Replay
>
> No need to write ALPM configuration for DP2.0 Panel Replay or PSR1.
>
> Signed-off-by: Jouni Högander <jouni.hogander@xxxxxxxxx>
> ---
> drivers/gpu/drm/i915/display/intel_psr.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/display/intel_psr.c
> b/drivers/gpu/drm/i915/display/intel_psr.c
> index 4cd2bad5241f..c7bda37444f0 100644
> --- a/drivers/gpu/drm/i915/display/intel_psr.c
> +++ b/drivers/gpu/drm/i915/display/intel_psr.c
> @@ -1699,7 +1699,8 @@ static void lnl_alpm_configure(struct intel_dp
> *intel_dp)
> struct intel_psr *psr = &intel_dp->psr;
> u32 alpm_ctl;
>
> - if (DISPLAY_VER(dev_priv) < 20)
> + if (DISPLAY_VER(dev_priv) < 20 || (!intel_dp->psr.psr2_enabled &&
> + !intel_dp_is_edp(intel_dp)))
This patch maybe good to squash with previous patch, not sure will there be any negative impact if panel does not support aux-less alpm and from source side it is enabled.
Regards,
Animesh
> return;
>
> if (intel_dp->psr.panel_replay_enabled &&
> intel_dp_is_edp(intel_dp)) {
> --
> 2.34.1
