On Tue, 12 Mar 2024, Thomas Weißschuh <thomas.weissschuh@xxxxxxxxxxxxx> wrote: > On Wed, Feb 28, 2024 at 01:32:33PM -0800, Radhakrishna Sripada wrote: >> We want to later change intel_opregion_get_vbt to duplicate the vbt >> memory if present, which would be an overkill when we just want to >> peek into the presence of opregion vbt. Carve out the presence check >> into its own function to use in places where only the presence of vbt >> is required. > > This doesn't compile when CONFIG_ACPI is not enabled: > > CC [M] drivers/gpu/drm/xe/i915-display/intel_bios.o > drivers/gpu/drm/i915/display/intel_bios.c: In function 'intel_bios_is_lvds_present': > drivers/gpu/drm/i915/display/intel_bios.c:3425:24: error: implicit declaration of function 'intel_opregion_vbt_present'; did you mean > 'intel_opregion_asle_present'? [-Werror=implicit-function-declaration] > 3425 | return intel_opregion_vbt_present(i915); > | ^~~~~~~~~~~~~~~~~~~~~~~~~~ > | intel_opregion_asle_present > cc1: all warnings being treated as errors > > Seen on next-20240312. Thanks for the report, fix at https://lore.kernel.org/r/20240312115757.683584-1-jani.nikula@xxxxxxxxx BR, Jani. -- Jani Nikula, Intel
