== Series Details == Series: Disable automatic load CCS load balancing (rev7) URL : https://patchwork.freedesktop.org/series/129951/ State : warning == Summary == Error: dim checkpatch failed 7e72bbeacb12 drm/i915/gt: Disable HW load balancing for CCS 181bfab6a479 drm/i915/gt: Refactor uabi engine class/instance list creation -:55: WARNING:AVOID_BUG: Do not crash the kernel unless it is absolutely unavoidable--use WARN_ON_ONCE() plus recovery code (if feasible) instead of BUG() or variants #55: FILE: drivers/gpu/drm/i915/gt/intel_engine_user.c:233: + GEM_BUG_ON(uabi_class >= ARRAY_SIZE(class_instance)); -:71: WARNING:AVOID_BUG: Do not crash the kernel unless it is absolutely unavoidable--use WARN_ON_ONCE() plus recovery code (if feasible) instead of BUG() or variants #71: FILE: drivers/gpu/drm/i915/gt/intel_engine_user.c:247: + GEM_BUG_ON(uabi_class >= total: 0 errors, 2 warnings, 0 checks, 56 lines checked df660f09b780 drm/i915/gt: Disable tests for CCS engines beyond the first -:26: ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses #26: FILE: drivers/gpu/drm/i915/gt/intel_gt.h:195: +#define for_each_available_engine(engine__, gt__, id__) \ + for ((id__) = 0; \ + (id__) < I915_NUM_ENGINES; \ + (id__)++) \ + for_each_if \ + (((engine__) = (gt__)->engine[(id__)]) && \ + !(engine__->class == COMPUTE_CLASS && \ + engine__->instance)) -:26: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'engine__' - possible side-effects? #26: FILE: drivers/gpu/drm/i915/gt/intel_gt.h:195: +#define for_each_available_engine(engine__, gt__, id__) \ + for ((id__) = 0; \ + (id__) < I915_NUM_ENGINES; \ + (id__)++) \ + for_each_if \ + (((engine__) = (gt__)->engine[(id__)]) && \ + !(engine__->class == COMPUTE_CLASS && \ + engine__->instance)) -:26: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'id__' - possible side-effects? #26: FILE: drivers/gpu/drm/i915/gt/intel_gt.h:195: +#define for_each_available_engine(engine__, gt__, id__) \ + for ((id__) = 0; \ + (id__) < I915_NUM_ENGINES; \ + (id__)++) \ + for_each_if \ + (((engine__) = (gt__)->engine[(id__)]) && \ + !(engine__->class == COMPUTE_CLASS && \ + engine__->instance)) total: 1 errors, 0 warnings, 2 checks, 107 lines checked bd63173366d9 drm/i915/gt: Enable only one CCS for compute workload Traceback (most recent call last): File "scripts/spdxcheck.py", line 6, in <module> from ply import lex, yacc ModuleNotFoundError: No module named 'ply' Traceback (most recent call last): File "scripts/spdxcheck.py", line 6, in <module> from ply import lex, yacc ModuleNotFoundError: No module named 'ply' -:16: WARNING:COMMIT_LOG_LONG_LINE: Prefer a maximum 75 chars per line (possible unwrapped commit description?) #16: Requires: 075e003a9e22 ("drm/i915/gt: Refactor uabi engine class/instance list creation") -:66: WARNING:FILE_PATH_CHANGES: added, moved or deleted file(s), does MAINTAINERS need updating? #66: new file mode 100644 -:140: CHECK:MACRO_ARG_PRECEDENCE: Macro argument 'cslice' may be better as '(cslice)' to avoid precedence issues #140: FILE: drivers/gpu/drm/i915/gt/intel_gt_regs.h:1486: +#define XEHP_CCS_MODE_CSLICE(cslice, ccs) (ccs << (cslice * XEHP_CCS_MODE_CSLICE_WIDTH)) -:140: CHECK:MACRO_ARG_PRECEDENCE: Macro argument 'ccs' may be better as '(ccs)' to avoid precedence issues #140: FILE: drivers/gpu/drm/i915/gt/intel_gt_regs.h:1486: +#define XEHP_CCS_MODE_CSLICE(cslice, ccs) (ccs << (cslice * XEHP_CCS_MODE_CSLICE_WIDTH)) total: 0 errors, 2 warnings, 2 checks, 112 lines checked
