✗ Fi.CI.CHECKPATCH: warning for Bigjoiner refactoring (rev9)

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



== Series Details ==

Series: Bigjoiner refactoring (rev9)
URL   : https://patchwork.freedesktop.org/series/128311/
State : warning

== Summary ==

Error: dim checkpatch failed
1a027433f244 Add a small helper to compute the set of pipes that the current crtc is using.
6fc2f34fb53f drm/i915: Extract intel_ddi_post_disable_hdmi_or_sst()
-:78: CHECK:BRACES: Blank lines aren't necessary after an open brace '{'
#78: FILE: drivers/gpu/drm/i915/display/intel_ddi.c:3136:
+{
+

total: 0 errors, 0 warnings, 1 checks, 57 lines checked
4b6fa47b432f drm/i915: Utilize intel_crtc_joined_pipe_mask() more
5d3691d1eab6 drm/i915: Handle joined pipes inside hsw_crtc_disable()
-:131: ERROR:CODE_INDENT: code indent should use tabs where possible
#131: FILE: drivers/gpu/drm/i915/display/intel_display.c:6838:
+                if (intel_crtc_is_bigjoiner_slave(old_crtc_state))$

-:131: WARNING:LEADING_SPACE: please, no spaces at the start of a line
#131: FILE: drivers/gpu/drm/i915/display/intel_display.c:6838:
+                if (intel_crtc_is_bigjoiner_slave(old_crtc_state))$

-:132: ERROR:CODE_INDENT: code indent should use tabs where possible
#132: FILE: drivers/gpu/drm/i915/display/intel_display.c:6839:
+                        continue;$

-:132: WARNING:LEADING_SPACE: please, no spaces at the start of a line
#132: FILE: drivers/gpu/drm/i915/display/intel_display.c:6839:
+                        continue;$

total: 2 errors, 2 warnings, 0 checks, 111 lines checked
a7dd46a67f2a drm/i915: Handle joined pipes inside hsw_crtc_enable()
-:8: WARNING:COMMIT_LOG_LONG_LINE: Prefer a maximum 75 chars per line (possible unwrapped commit description?)
#8: 
That way we can also remove a bunch of checks like intel_crtc_is_bigjoiner_slave.

-:240: WARNING:BLOCK_COMMENT_STYLE: Block comments use a trailing */ on a separate line
#240: FILE: drivers/gpu/drm/i915/display/intel_display.c:1718:
+		 * to change the workaround. */

-:293: ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses
#293: FILE: drivers/gpu/drm/i915/display/intel_display.h:315:
+#define for_each_intel_crtc_in_pipe_mask_reverse(dev, intel_crtc, pipe_mask)	\
+	list_for_each_entry_reverse(intel_crtc,					\
+				    &(dev)->mode_config.crtc_list,		\
+				    base.head)					\
+		for_each_if((pipe_mask) & BIT(intel_crtc->pipe))

-:293: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'intel_crtc' - possible side-effects?
#293: FILE: drivers/gpu/drm/i915/display/intel_display.h:315:
+#define for_each_intel_crtc_in_pipe_mask_reverse(dev, intel_crtc, pipe_mask)	\
+	list_for_each_entry_reverse(intel_crtc,					\
+				    &(dev)->mode_config.crtc_list,		\
+				    base.head)					\
+		for_each_if((pipe_mask) & BIT(intel_crtc->pipe))

total: 1 errors, 2 warnings, 1 checks, 272 lines checked
fe6c742eb717 drm/i915: Allow bigjoiner for MST





[Index of Archives]     [AMD Graphics]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux