Re: [PATCH v15 3/9] drm: Add crtc state dump for Adaptive Sync SDP

["Nautiyal, Ankit K" <ankit.k.nautiyal@xxxxxxxxx>]

Add drm/i915/display in subject line.

With that fixed this is:

Reviewed-by: Ankit Nautiyal <ankit.k.nautiyal@xxxxxxxxx>

On 3/1/2024 2:14 PM, Mitul Golani wrote:
> Add crtc state dump for Adaptive Sync SDP to know which
> crtc specifically caused the failure.
>
> Signed-off-by: Mitul Golani <mitulkumar.ajitkumar.golani@xxxxxxxxx>
> ---
>   .../gpu/drm/i915/display/intel_crtc_state_dump.c    | 13 +++++++++++++
>   drivers/gpu/drm/i915/display/intel_display_types.h  |  1 +
>   2 files changed, 14 insertions(+)
>
> diff --git a/drivers/gpu/drm/i915/display/intel_crtc_state_dump.c b/drivers/gpu/drm/i915/display/intel_crtc_state_dump.c
> index 4bcf446c75f4..1e4618271156 100644
> --- a/drivers/gpu/drm/i915/display/intel_crtc_state_dump.c
> +++ b/drivers/gpu/drm/i915/display/intel_crtc_state_dump.c
> @@ -51,6 +51,15 @@ intel_dump_infoframe(struct drm_i915_private *i915,
>   	hdmi_infoframe_log(KERN_DEBUG, i915->drm.dev, frame);
>   }
>   
> +static void
> +intel_dump_dp_as_sdp(struct drm_i915_private *i915,
> +		     const struct drm_dp_as_sdp *as_sdp)
> +{
> +	struct drm_printer p = drm_dbg_printer(&i915->drm, DRM_UT_KMS, "AS_SDP");
> +
> +	drm_dp_as_sdp_log(&p, as_sdp);
> +}
> +
>   static void
>   intel_dump_dp_vsc_sdp(struct drm_i915_private *i915,
>   		      const struct drm_dp_vsc_sdp *vsc)
> @@ -302,6 +311,10 @@ void intel_crtc_state_dump(const struct intel_crtc_state *pipe_config,
>   	if (pipe_config->infoframes.enable &
>   	    intel_hdmi_infoframe_enable(DP_SDP_VSC))
>   		intel_dump_dp_vsc_sdp(i915, &pipe_config->infoframes.vsc);
> +	if (pipe_config->infoframes.enable &
> +	    intel_hdmi_infoframe_enable(DP_SDP_ADAPTIVE_SYNC))
> +		intel_dump_dp_as_sdp(i915, &pipe_config->infoframes.as_sdp);
> +
>   
>   	if (pipe_config->has_audio)
>   		intel_dump_buffer(i915, "ELD: ", pipe_config->eld,
> diff --git a/drivers/gpu/drm/i915/display/intel_display_types.h b/drivers/gpu/drm/i915/display/intel_display_types.h
> index 860e867586f4..098957cea25b 100644
> --- a/drivers/gpu/drm/i915/display/intel_display_types.h
> +++ b/drivers/gpu/drm/i915/display/intel_display_types.h
> @@ -1338,6 +1338,7 @@ struct intel_crtc_state {
>   		union hdmi_infoframe hdmi;
>   		union hdmi_infoframe drm;
>   		struct drm_dp_vsc_sdp vsc;
> +		struct drm_dp_as_sdp as_sdp;
>   	} infoframes;
>   
>   	u8 eld[MAX_ELD_BYTES];