> -----Original Message----- > From: Nikula, Jani <jani.nikula@xxxxxxxxx> > Sent: Thursday, February 29, 2024 4:08 PM > To: Golani, Mitulkumar Ajitkumar <mitulkumar.ajitkumar.golani@xxxxxxxxx>; > intel-gfx@xxxxxxxxxxxxxxxxxxxxx > Cc: dri-devel@xxxxxxxxxxxxxxxxxxxxx; Nautiyal, Ankit K > <ankit.k.nautiyal@xxxxxxxxx>; Golani, Mitulkumar Ajitkumar > <mitulkumar.ajitkumar.golani@xxxxxxxxx> > Subject: Re: [PATCH v12 2/8] drm: Add Adaptive Sync SDP logging > > On Wed, 28 Feb 2024, Mitul Golani <mitulkumar.ajitkumar.golani@xxxxxxxxx> > wrote: > > Add structure representing Adaptive Sync Secondary Data Packet (AS SDP). > > Also, add Adaptive Sync SDP logging in drm_dp_helper.c to facilitate > > debugging. > > To be honest, the division of patches is a bit weird. There's no reason to change > i915 here, is there? > Hi Jani, Thought behind this was to use the function where it was defined. But no worries, I have split it with new patch series floated. Regards, Mitul