> -----Original Message-----
> From: Jani Nikula <jani.nikula@xxxxxxxxxxxxxxx>
> Sent: Wednesday, February 28, 2024 2:39 PM
> To: Srinivas, Vidya <vidya.srinivas@xxxxxxxxx>; intel-gfx@xxxxxxxxxxxxxxxxxxxxx
> Cc: Almahallawy, Khaled <khaled.almahallawy@xxxxxxxxx>; Srinivas, Vidya
> <vidya.srinivas@xxxxxxxxx>
> Subject: Re: [PATCH 1/2] Revert "drm/i915/mst: Reject modes that require the
> bigjoiner"
>
> On Tue, 27 Feb 2024, Vidya Srinivas <vidya.srinivas@xxxxxxxxx> wrote:
> > This reverts commit 9c058492b16f90bb772cb0dad567e8acc68e155d.
> >
> > Reverting for adding MST bigjoiner functionality.
>
> Please squash this together with the fix. Someone might think a revert is a fix
> that needs to be backported. Besides, for bisection this creates a non-working
> commit.
Hello Jani
Thank you very much. Sure, I will squash it together with the fix and submit.
Regards
Vidya
>
> BR,
> Jani.
>
>
> >
> > Signed-off-by: Vidya Srinivas <vidya.srinivas@xxxxxxxxx>
> > ---
> > drivers/gpu/drm/i915/display/intel_dp_mst.c | 4 ----
> > 1 file changed, 4 deletions(-)
> >
> > diff --git a/drivers/gpu/drm/i915/display/intel_dp_mst.c
> > b/drivers/gpu/drm/i915/display/intel_dp_mst.c
> > index db1254b036f1..b062f4ee6c8b 100644
> > --- a/drivers/gpu/drm/i915/display/intel_dp_mst.c
> > +++ b/drivers/gpu/drm/i915/display/intel_dp_mst.c
> > @@ -1349,10 +1349,6 @@ intel_dp_mst_mode_valid_ctx(struct
> drm_connector *connector,
> > if (intel_dp_need_bigjoiner(intel_dp, mode->hdisplay, target_clock)) {
> > bigjoiner = true;
> > max_dotclk *= 2;
> > -
> > - /* TODO: add support for bigjoiner */
> > - *status = MODE_CLOCK_HIGH;
> > - return 0;
> > }
> >
> > if (DISPLAY_VER(dev_priv) >= 10 &&
>
> --
> Jani Nikula, Intel
