On Tue, 20 Feb 2024 at 20:53, Abhinav Kumar <quic_abhinavk@xxxxxxxxxxx> wrote: > > > > On 2/20/2024 10:49 AM, Dmitry Baryshkov wrote: > > On Thu, 15 Feb 2024 at 21:08, Abhinav Kumar <quic_abhinavk@xxxxxxxxxxx> wrote: > >> > >> intel_dp_vsc_sdp_pack() can be re-used by other DRM drivers as well. > >> Lets move this to drm_dp_helper to achieve this. > >> > >> changes in v2: > >> - rebased on top of drm-tip > >> > >> Acked-by: Dmitry Baryshkov <dmitry.baryshkov@xxxxxxxxxx> > > > > v1 had an explicit comment before the ack: > > > > Yes, I remember the comment. I did not make any changes to v2 other than > just rebasing it on drm-tip to get the ack from i915 folks. > > >> From my side, with the promise of the size fixup. > > > > However I observe neither a second patch removing the size argument > > nor it being dropped as a part of this patch. > > > > Yes, now that in v2 we got the ack for this patch, I can spin a v3 with > the addition of the next patch to remove the size OR as another series > so as to not block the main series which needs this patch. > > I would prefer the latter. It doesn't work this way. The comment should have been fixed for v2. -- With best wishes Dmitry
