On Mon, 2024-02-19 at 13:25 +0000, Tvrtko Ursulin wrote: > From: Tvrtko Ursulin <tvrtko.ursulin@xxxxxxxxx> > > Tooling appears very strict so lets pacify it by adding some comments, > even if fields are completely self-explanatory. > Reviewed-by: José Roberto de Souza <jose.souza@xxxxxxxxx> > Signed-off-by: Tvrtko Ursulin <tvrtko.ursulin@xxxxxxxxx> > Fixes: b11236486749 ("drm/i915: Add GuC submission interface version query") > Reported-by: Stephen Rothwell <sfr@xxxxxxxxxxxxxxxx> > Cc: Jose Souza <jose.souza@xxxxxxxxx> > --- > include/uapi/drm/i915_drm.h | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/include/uapi/drm/i915_drm.h b/include/uapi/drm/i915_drm.h > index bd87386a8243..2ee338860b7e 100644 > --- a/include/uapi/drm/i915_drm.h > +++ b/include/uapi/drm/i915_drm.h > @@ -3572,9 +3572,13 @@ struct drm_i915_query_memory_regions { > * struct drm_i915_query_guc_submission_version - query GuC submission interface version > */ > struct drm_i915_query_guc_submission_version { > + /** @branch: Firmware branch version. */ > __u32 branch; > + /** @major: Firmware major version. */ > __u32 major; > + /** @minor: Firmware minor version. */ > __u32 minor; > + /** @patch: Firmware patch version. */ > __u32 patch; > }; >