Hi Jouni, kernel test robot noticed the following build warnings: https://git-scm.com/docs/git-format-patch#_base_tree_information] url: https://github.com/intel-lab-lkp/linux/commits/Jouni-H-gander/drm-display-Add-missing-aux-less-alpm-wake-related-bits/20240215-185209 base: git://anongit.freedesktop.org/drm-intel for-linux-next patch link: https://lore.kernel.org/r/20240215104934.2395239-5-jouni.hogander%40intel.com patch subject: [PATCH 4/6] drm/i915/psr: Silence period and lfps half cycle config: i386-randconfig-141-20240217 (https://download.01.org/0day-ci/archive/20240217/202402171830.n4hwR2iD-lkp@xxxxxxxxx/config) compiler: clang version 17.0.6 (https://github.com/llvm/llvm-project 6009708b4367171ccdbf4b5905cb6a803753fe18) If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot <lkp@xxxxxxxxx> | Reported-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx> | Closes: https://lore.kernel.org/r/202402171830.n4hwR2iD-lkp@xxxxxxxxx/ smatch warnings: drivers/gpu/drm/i915/display/intel_psr.c:1253 _lnl_compute_aux_less_alpm_params() error: uninitialized symbol 'silence_period'. vim +/silence_period +1253 drivers/gpu/drm/i915/display/intel_psr.c e4870a4a3cd051 Jouni Högander 2024-02-15 1235 static int _lnl_compute_aux_less_alpm_params(struct intel_dp *intel_dp, e4870a4a3cd051 Jouni Högander 2024-02-15 1236 struct intel_crtc_state *crtc_state) e4870a4a3cd051 Jouni Högander 2024-02-15 1237 { e4870a4a3cd051 Jouni Högander 2024-02-15 1238 struct drm_i915_private *i915 = dp_to_i915(intel_dp); 410818227325ec Jouni Högander 2024-02-15 1239 int aux_less_wake_time, aux_less_wake_lines, switch_to_active_lines, 410818227325ec Jouni Högander 2024-02-15 1240 silence_period, lfps_half_cycle; e4870a4a3cd051 Jouni Högander 2024-02-15 1241 e4870a4a3cd051 Jouni Högander 2024-02-15 1242 aux_less_wake_time = e4870a4a3cd051 Jouni Högander 2024-02-15 1243 _lnl_compute_aux_less_wake_time(crtc_state->port_clock / 1000); e4870a4a3cd051 Jouni Högander 2024-02-15 1244 aux_less_wake_lines = intel_usecs_to_scanlines(&crtc_state->hw.adjusted_mode, e4870a4a3cd051 Jouni Högander 2024-02-15 1245 aux_less_wake_time); e4870a4a3cd051 Jouni Högander 2024-02-15 1246 e31171d1611687 Jouni Högander 2024-02-15 1247 switch_to_active_lines = e31171d1611687 Jouni Högander 2024-02-15 1248 intel_usecs_to_scanlines( e31171d1611687 Jouni Högander 2024-02-15 1249 &crtc_state->hw.adjusted_mode, e31171d1611687 Jouni Högander 2024-02-15 1250 _lnl_compute_switch_to_active_time(crtc_state->port_clock / 1000)); e31171d1611687 Jouni Högander 2024-02-15 1251 410818227325ec Jouni Högander 2024-02-15 1252 if (aux_less_wake_lines > 32 || switch_to_active_lines > 32 || 410818227325ec Jouni Högander 2024-02-15 @1253 silence_period > 256 || silence_period < 0 || ^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^ Uninitialized 410818227325ec Jouni Högander 2024-02-15 1254 !_lnl_get_silence_period_and_lfps_half_cycle(intel_dp->link_rate, 410818227325ec Jouni Högander 2024-02-15 1255 &silence_period, 410818227325ec Jouni Högander 2024-02-15 1256 &lfps_half_cycle)) e4870a4a3cd051 Jouni Högander 2024-02-15 1257 return false; e4870a4a3cd051 Jouni Högander 2024-02-15 1258 e31171d1611687 Jouni Högander 2024-02-15 1259 if (i915->display.params.psr_safest_params) { e4870a4a3cd051 Jouni Högander 2024-02-15 1260 aux_less_wake_lines = 32; e31171d1611687 Jouni Högander 2024-02-15 1261 switch_to_active_lines = 32; e31171d1611687 Jouni Högander 2024-02-15 1262 } e4870a4a3cd051 Jouni Högander 2024-02-15 1263 e4870a4a3cd051 Jouni Högander 2024-02-15 1264 intel_dp->psr.alpm_parameters.aux_less_wake_lines = aux_less_wake_lines; e31171d1611687 Jouni Högander 2024-02-15 1265 intel_dp->psr.alpm_parameters.switch_to_active_lines = switch_to_active_lines; 410818227325ec Jouni Högander 2024-02-15 1266 intel_dp->psr.alpm_parameters.silence_period_sym_clocks = silence_period; 410818227325ec Jouni Högander 2024-02-15 1267 intel_dp->psr.alpm_parameters.lfps_half_cycle_num_of_syms = lfps_half_cycle; e4870a4a3cd051 Jouni Högander 2024-02-15 1268 e4870a4a3cd051 Jouni Högander 2024-02-15 1269 return true; e4870a4a3cd051 Jouni Högander 2024-02-15 1270 } -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki
